Re: [PATCH 4/5] SLIP: Add error message for xleft non-zero

Greg Kroah-Hartman
2013-07-24T22:18:51Z

On Tue, Jul 02, 2013 at 04:31:33PM +0100, Dean Jenkins wrote:
> Add a printk to show when xleft is non-zero in sl_encaps.
>
> The idea is to see whether a previous SLIP frame failed to be
> fully transmitted.
>
> Signed-off-by: Dean Jenkins <Dean_Jenkins@mentor.com>
> ---
> drivers/net/slip/slip.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c
> index f7303e0..e2eff84 100644
> --- a/drivers/net/slip/slip.c
> +++ b/drivers/net/slip/slip.c
> @@ -395,6 +395,10 @@ static void sl_encaps(struct slip *sl, unsigned char *icp, int len)
> #endif
> count = slip_esc(p, sl->xbuff, len);
>
> + if (sl->xleft)
> + printk(KERN_ERR "%s: ERROR: xleft is non-zero %d\n",
> + __func__, sl->xleft);

dev_err() perhaps?

thanks,

greg k-h