From: Michael Wang <wangyun@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Rakib Mullick <rakib.mullick@gmail.com>,
mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched: update_top_cache_domain only at the times of building sched domain.
Date: Thu, 25 Jul 2013 10:49:54 +0800 [thread overview]
Message-ID: <51F09252.3080102@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130724104931.GF27075@twins.programming.kicks-ass.net>
On 07/24/2013 06:49 PM, Peter Zijlstra wrote:
> On Wed, Jul 24, 2013 at 04:34:39PM +0800, Michael Wang wrote:
>> But your patch will run the risk to get a freed sd, since you make
>> 'sd_llc' wrong for a period of time (between destroy and rebuild) IMO.
>>
>> I guess I get you point, you are trying to save one time update since
>> you think this will be done twice, but actually the result of this two
>> time update was different, it's not redo and it's in order to sync
>> 'sd_llc' with 'rq->sd'.
>
> Michael is right, you cannot skip update_top_cache_domain() when
> destroying things.
Thanks for the confirm :)
Regards,
Michael Wang
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2013-07-25 2:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 17:42 [PATCH v2] sched: update_top_cache_domain only at the times of building sched domain Rakib Mullick
2013-07-24 3:26 ` Michael Wang
2013-07-24 8:01 ` Rakib Mullick
2013-07-24 8:34 ` Michael Wang
2013-07-24 10:49 ` Peter Zijlstra
2013-07-25 2:49 ` Michael Wang [this message]
2013-07-24 13:57 ` Rakib Mullick
2013-07-25 3:15 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F09252.3080102@linux.vnet.ibm.com \
--to=wangyun@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).