From: Daniel Mack <zonque@gmail.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: v3.11-rc1 USB regressions
Date: Thu, 25 Jul 2013 11:08:03 +0200 [thread overview]
Message-ID: <51F0EAF3.1060606@gmail.com> (raw)
In-Reply-To: <20130725003029.GD26943@blackmetal.musicnaut.iki.fi>
On 25.07.2013 02:30, Aaro Koskinen wrote:
> On Wed, Jul 24, 2013 at 09:04:28PM +0200, Daniel Mack wrote:
>> On 24.07.2013 20:51, Aaro Koskinen wrote:
>>>> When I revert fe4cb0912f8e737f8e4b8b38b9e692f8062f5423 and
>>>> 8b125df5b24cfb0ec7fa1971e343cc0badc1827d, it works like before (3.10):
>>>
>>> I'm now running -rc2 with above fixes and reverts (the only way to get
>>> USB working). I'm seeing an additional issue, the following crash happens
>>> always on N900 when doing "poweroff":
>>
>> Yes, with the mentioned patches reverted, musb_to_hcd() will return a
>> faulty pointer. You can't easily revert them unfortunately.
>>
>> Your platform needs a real fix, I just have trouble understanding why a
>> removed usb_add_hcd() would make the gadget code fail.
>>
>> Sorry for the trouble, but I don't currently have a board with musb in
>> gadget mode to reproduce this issue.
>
> If you have any ideas what to look for, I can maybe try to debug this
> issue.
Please try changing the .mode field of musb_board_data to MUSB_OTG in
your board file (arch/arm/mach-omap2/board-rx51.c). That should bring
back the call to usb_add_hcd(), provided that you have USB_MUSB_DUAL_ROLE=y.
I still don't see a reason why this is should be necessary for
peripheral-only use though.
Daniel
prev parent reply other threads:[~2013-07-25 9:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 22:56 v3.11-rc1 USB regressions Aaro Koskinen
2013-07-16 6:33 ` Daniel Mack
2013-07-16 7:00 ` Kishon Vijay Abraham I
2013-07-16 8:08 ` Felipe Balbi
2013-07-16 8:22 ` Felipe Balbi
2013-07-16 18:26 ` Aaro Koskinen
2013-07-16 18:30 ` Daniel Mack
2013-07-16 18:34 ` Aaro Koskinen
2013-07-16 17:30 ` Aaro Koskinen
2013-07-16 17:57 ` Aaro Koskinen
2013-07-24 18:51 ` Aaro Koskinen
2013-07-24 19:04 ` Daniel Mack
2013-07-25 0:30 ` Aaro Koskinen
2013-07-25 9:08 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F0EAF3.1060606@gmail.com \
--to=zonque@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox