From: Michal Marek <mmarek@suse.cz>
To: Frank Haverkamp <haver@vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, cody@linux.vnet.ibm.com,
schwidefsky@de.ibm.com, utz.bacher@de.ibm.com, jsvogt@de.ibm.com,
MIJUNG@de.ibm.com, cascardo@linux.vnet.ibm.com, michael@ibmra.de
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver
Date: Thu, 25 Jul 2013 15:21:44 +0200 [thread overview]
Message-ID: <51F12668.8000400@suse.cz> (raw)
In-Reply-To: <1374740897-20304-2-git-send-email-haver@vnet.ibm.com>
On 25.7.2013 10:28, Frank Haverkamp wrote:
> + dev_info(&pci_dev->dev, "GenWQE driver version: %s (build %s) %s%u\n",
> + DRV_VERS_STRING, __DATE__, GENWQE_DEVNAME, cd->card_idx);
[...]
> + len += scnprintf(&buf[len], PAGE_SIZE - len,
> + "GenWQE driver version: %s (build %s)\n"
> + " Device Name/Type: %s %s CardIdx: %d\n"
> + " SLU/APP Config : 0x%016llx/0x%016llx\n"
> + " Build Date/Type : %u/%x/%u %s\n"
> + " Base Clock : %u MHz\n"
> + " Arch/SVN Release: %u/%llx\n"
> + " Bitstream : %llx\n",
> + DRV_VERS_STRING, __DATE__, dev_name(&pci_dev->dev),
Please remove the __DATE__ macros, so that the generated object code
does not literally change with the phase of the moon.
Michal
next prev parent reply other threads:[~2013-07-25 13:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 8:28 [RFC] [PATCH] Generic WorkQueue Engine (GenWQE) device driver Frank Haverkamp
2013-07-25 8:28 ` Frank Haverkamp
2013-07-25 13:21 ` Michal Marek [this message]
2013-07-26 12:20 ` Frank Haverkamp
2013-07-26 12:29 ` Michal Marek
2013-10-23 13:15 ` Frank Haverkamp
2013-10-23 13:40 ` Michal Marek
2013-10-23 14:14 ` Frank Haverkamp
2013-10-23 15:06 ` Michal Marek
2013-10-23 15:22 ` Greg KH
2013-10-23 18:15 ` Guenter Roeck
2013-10-24 9:56 ` Greg KH
2013-10-23 14:54 ` Greg KH
2013-10-23 18:27 ` Bjorn Helgaas
2013-10-25 7:56 ` Frank Haverkamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F12668.8000400@suse.cz \
--to=mmarek@suse.cz \
--cc=MIJUNG@de.ibm.com \
--cc=arnd@arndb.de \
--cc=cascardo@linux.vnet.ibm.com \
--cc=cody@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=haver@vnet.ibm.com \
--cc=jsvogt@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ibmra.de \
--cc=schwidefsky@de.ibm.com \
--cc=utz.bacher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox