Re: [RESEND RFC PATCH 2/5] printk: add message hash values in /dev/kmsg output

[Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>]

Hello,

(2013/07/26 0:01), Kazuo Ito wrote:> Hello, again.
>
> On Thu, Jul 25, 2013 at 5:37 PM, Hidehiro Kawai <
> hidehiro.kawai.ez@hitachi.com> wrote:
>
>> diff --git a/drivers/base/core.c b/drivers/base/core.c
>> index 8856d74..e2bf2af 100644
>> --- a/drivers/base/core.c
>> +++ b/drivers/base/core.c
>> @@ -2153,7 +2153,8 @@ int dev_vprintk_emit(int level, const struct device
>> *dev,
>>
>>         hdrlen = create_syslog_header(dev, hdr, sizeof(hdr));
>>
>> -       return vprintk_emit(0, level, hdrlen ? hdr : NULL, hdrlen, fmt,
>> args);
>> +       return vprintk_emit(0, level, hdrlen ? hdr : NULL, hdrlen,
>> +                           fmt, args, NULL);
>>  }
>>  EXPORT_SYMBOL(dev_vprintk_emit);
>>
>
>
>
> Position of struct kmsg_meta * arguments can be made more
> consistent. Because it can occur with va_list which comes
> last by convention, it should be brought to front of these
> lists of arguments. 

You are right.  It should be consistent.

So I will place kmsg_meta * in the front of fmt in the next version.
It would be preferred that the format string immediately followed by
variable arguments.

Regards,
-- 
Hidehiro Kawai
Hitachi, Yokohama Research Laboratory
Linux Technology Center