From: Rik van Riel <riel@redhat.com>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Jeremy Eder <jeder@redhat.com>,
linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com,
youquan.song@intel.com, paulmck@linux.vnet.ibm.com,
daniel.lezcano@linaro.org, len.brown@intel.com
Subject: Re: RFC: revert request for cpuidle patches e11538d1 and 69a37bea
Date: Fri, 26 Jul 2013 14:29:40 -0400 [thread overview]
Message-ID: <51F2C014.90102@redhat.com> (raw)
In-Reply-To: <51F2BF8C.7010308@linux.intel.com>
On 07/26/2013 02:27 PM, Arjan van de Ven wrote:
> On 7/26/2013 11:13 AM, Rik van Riel wrote:
>
>>
>> Could you try running the tests with just the repeat mode
>> stuff from commit 69a37bea excluded, but leaving the common
>> infrastructure and commit e11538?
>>
>
> personally I think we should go the other way around.
> revert the set entirely first, and now, and get our performance back
> to what it should be
>
> and then see what we can add back without causing the regressions.
> this may take longer, or be done in steps, and that's ok.
>
> the end point may well be the same... but we can then evaluate in the right
> direction.
Works for me. I have no objection to reverting both patches,
if the people planning to fix the code prefer that :)
--
All rights reversed
next prev parent reply other threads:[~2013-07-26 18:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 17:33 RFC: revert request for cpuidle patches e11538d1 and 69a37bea Jeremy Eder
2013-07-26 18:13 ` Rik van Riel
2013-07-26 18:27 ` Arjan van de Ven
2013-07-26 18:29 ` Rik van Riel [this message]
2013-07-26 21:48 ` Rafael J. Wysocki
2013-07-27 0:36 ` Rafael J. Wysocki
2013-07-27 6:22 ` Len Brown
2013-07-27 12:10 ` Rafael J. Wysocki
2013-07-27 7:11 ` Daniel Lezcano
2013-07-29 11:49 ` Arjan van de Ven
2013-07-29 13:12 ` Arjan van de Ven
2013-07-29 14:14 ` Lorenzo Pieralisi
2013-07-29 14:29 ` Arjan van de Ven
2013-07-29 16:01 ` Lorenzo Pieralisi
2013-07-29 16:04 ` Arjan van de Ven
2013-07-27 6:43 ` Daniel Lezcano
2013-07-30 3:57 ` Youquan Song
2013-07-29 16:59 ` Jeremy Eder
2013-08-02 18:19 ` Jeremy Eder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F2C014.90102@redhat.com \
--to=riel@redhat.com \
--cc=arjan@linux.intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=jeder@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).