From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Brown <broonie@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"rob@landley.net" <rob@landley.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
"kishon@ti.com" <kishon@ti.com>,
Stephen Warren <swarren@nvidia.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] drivers/rtc/rtc-palmas.c: support for backup battery charging
Date: Sat, 27 Jul 2013 13:02:21 +0530 [thread overview]
Message-ID: <51F37785.9040604@nvidia.com> (raw)
In-Reply-To: <51F2A706.9080005@wwwdotorg.org>
On Friday 26 July 2013 10:12 PM, Stephen Warren wrote:
> On 07/26/2013 10:35 AM, Mark Brown wrote:
>> On Fri, Jul 26, 2013 at 09:40:15AM -0600, Stephen Warren wrote:
>>
>>> Given there's only 1 battery, I think "back-" is redundant in
>>> the property names. Since that shortens the names a bit, I'd
>>> suggest spelling everything out in full, perhaps:
>> Isn't there an integrated charger on the PMIC? If there is then
>> it's useful to identify which is being talked about (even if it
>> should be relatively obvious).
> Oh yes, that's probably true. This is of course the binding for the
> RTC sub-module in the PMIC though.
>
I have currently Palma series 2 devices tps65913 and tps80036. TPS80036
supports the charging of main battery. Both chip support the backup
battery charging. Hence it is good to name the back-* here.
next prev parent reply other threads:[~2013-07-27 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 12:29 [PATCH] drivers/rtc/rtc-palmas.c: support for backup battery charging Laxman Dewangan
2013-07-26 15:40 ` Stephen Warren
2013-07-26 15:52 ` Mark Rutland
2013-07-26 16:35 ` Mark Brown
2013-07-26 16:42 ` Stephen Warren
2013-07-27 7:32 ` Laxman Dewangan [this message]
2013-07-26 20:45 ` Tomasz Figa
2013-07-27 7:38 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F37785.9040604@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=Mark.Rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox