From: Lars-Peter Clausen <lars@metafoo.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <djbw@fb.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] dma: pl330: Fix cyclic transfers
Date: Sun, 28 Jul 2013 17:08:58 +0200 [thread overview]
Message-ID: <51F5340A.1090901@metafoo.de> (raw)
In-Reply-To: <20130728134546.GE1986@intel.com>
On 07/28/2013 03:45 PM, Vinod Koul wrote:
> On Tue, Jul 23, 2013 at 10:24:50AM +0200, Lars-Peter Clausen wrote:
>> Allocate a descriptor for each period of a cyclic transfer, not just the first.
>> Also since the callback needs to be called for each finished period make sure to
>> initialize the callback and callback_param fields of each descriptor in a cyclic
>> transfer.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Applied thanks
>
Thanks.
> Btw the switch moved should have return error for default case when direction is
> not slave, but thats not in context of this as you moved that code
Checking inside the loop makes the error handling more complicated since at
that point the descriptor is already allocated and needs to be freed again. So
we check this right at the beginning (Using is_slave_direction), so we'll never
get to the loop if the direction is not OK. The default statement is mainly
there to keep the compiler happy.
- Lars
prev parent reply other threads:[~2013-07-28 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 8:24 [PATCH v2] dma: pl330: Fix cyclic transfers Lars-Peter Clausen
2013-07-28 13:45 ` Vinod Koul
2013-07-28 15:08 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F5340A.1090901@metafoo.de \
--to=lars@metafoo.de \
--cc=djbw@fb.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox