* O_TMPFILE problem
@ 2013-07-28 16:35 Marco Stornelli
2013-07-29 13:22 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Marco Stornelli @ 2013-07-28 16:35 UTC (permalink / raw)
To: Al Viro, Linux Kernel, Linux FS Devel
Hi,
I'm doing a couple of test about O_TMPFILE on my fs. I can see that when
the file is closed the blocks allocated are not freed. It happens
because of i_mode, it isn't a regular file nor a directory nor a link. I
added S_IFREG in my implementation of tmpfile callback when I have to
call new_inode() and now it works, but am I missing something here?
Marco
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: O_TMPFILE problem
2013-07-28 16:35 O_TMPFILE problem Marco Stornelli
@ 2013-07-29 13:22 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2013-07-29 13:22 UTC (permalink / raw)
To: Marco Stornelli; +Cc: Al Viro, Linux Kernel, Linux FS Devel
On Sun 28-07-13 18:35:12, Marco Stornelli wrote:
> I'm doing a couple of test about O_TMPFILE on my fs. I can see that
> when the file is closed the blocks allocated are not freed. It
> happens because of i_mode, it isn't a regular file nor a directory
> nor a link. I added S_IFREG in my implementation of tmpfile callback
> when I have to call new_inode() and now it works, but am I missing
> something here?
No, I think you are right. We need to add S_IFREG to the mode we pass to
->tmpfile().
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-29 13:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-28 16:35 O_TMPFILE problem Marco Stornelli
2013-07-29 13:22 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox