From: Laxman Dewangan <ldewangan@nvidia.com>
To: Andrew Chew <achew@nvidia.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
Rhyland Klein <rklein@nvidia.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] gpio: palmas: Fix misreported GPIO out value
Date: Mon, 29 Jul 2013 11:30:13 +0530 [thread overview]
Message-ID: <51F604ED.5050109@nvidia.com> (raw)
In-Reply-To: <1374871193-403-1-git-send-email-achew@nvidia.com>
On Saturday 27 July 2013 02:09 AM, Andrew Chew wrote:
> It seems that the value read back from the PALMAS_GPIO_DATA_IN register
> isn't valid if the GPIO direction is out. When that's the case, we can
> read back the PALMAS_GPIO_DATA_OUT register to get the proper output value.
Looks good to me.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
next prev parent reply other threads:[~2013-07-29 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 20:39 [PATCH V2] gpio: palmas: Fix misreported GPIO out value Andrew Chew
2013-07-29 6:00 ` Laxman Dewangan [this message]
2013-08-16 13:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F604ED.5050109@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=achew@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rklein@nvidia.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).