public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rupesh Gujare <rupesh.gujare@atmel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <devel@linuxdriverproject.org>, <gregkh@linuxfoundation.org>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: ozwpan: High resolution timers
Date: Tue, 30 Jul 2013 14:48:35 +0100	[thread overview]
Message-ID: <51F7C433.6070005@atmel.com> (raw)
In-Reply-To: <20130730131230.GC5002@mwanda>

On 30/07/13 14:12, Dan Carpenter wrote:
> On Tue, Jul 30, 2013 at 01:31:50PM +0100, Rupesh Gujare wrote:
>> Current implementation assumes HZ = 1000 for calculating
>> all internal timer intervals, which creates problem on
>> platforms where HZ != 1000.
>>
>> As well we need resolution of less than 10 mSec for heartbeat
>> calculation, this creates problem on some platforms where HZ is
>> configured as HZ = 100, or around, which restricts us to timer interval
>> of 10 mSec. This is particularly found on embedded devices.
>>
>> This patch moves on to use high resolution timers to calculate
>> all timer intervals as it allows us to have very small resolution
>> of timer interval, removing dependency on HZ.
>>
> I am new to this driver.  So we batch all the transfers together and
> send/recieve them in oz_hcd_heartbeat() every 10msec?  It's a
> polling interface?
>
> Sorry, if I am completely mis-reading what this driver is doing.
>
> In other words, could you explain what oz_hcd_heartbeat() does.
>
>
>

Yes, you are right. USB service requests for regular heartbeat when it 
have URBs queued (at them moment every 8mSsec when ISOC endpoints are
configured). This heartbeat is also used by EP0 traffic to retransmit 
packet over WiFi.

At heartbeat expiry, oz_hcd_heartbeat(), goes on to process all received 
URBs and send it over WiFi.


-- 
Regards,
Rupesh Gujare


      reply	other threads:[~2013-07-30 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30 12:31 [PATCH] staging: ozwpan: High resolution timers Rupesh Gujare
2013-07-30 13:12 ` Dan Carpenter
2013-07-30 13:48   ` Rupesh Gujare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F7C433.6070005@atmel.com \
    --to=rupesh.gujare@atmel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox