public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Cgroups <cgroups@vger.kernel.org>
Subject: [PATCH 2/7] cgroup: remove sparse tags from offline_css()
Date: Wed, 31 Jul 2013 16:16:40 +0800	[thread overview]
Message-ID: <51F8C7E8.1080909@huawei.com> (raw)
In-Reply-To: <51F8C7C5.9040608@huawei.com>

This should have been removed in commit d7eeac1913ff
("cgroup: hold cgroup_mutex before calling css_offline").

While at it, update the comments.

Signed-off-by: Li Zefan <lizefan@huawei.com>
---
 kernel/cgroup.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index e60eba2..916a699 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -4164,7 +4164,7 @@ static void init_cgroup_css(struct cgroup_subsys_state *css,
 	INIT_WORK(&css->dput_work, css_dput_fn);
 }
 
-/* invoke ->post_create() on a new CSS and mark it online if successful */
+/* invoke ->css_online() on a new CSS and mark it online if successful */
 static int online_css(struct cgroup_subsys *ss, struct cgroup *cgrp)
 {
 	int ret = 0;
@@ -4178,9 +4178,8 @@ static int online_css(struct cgroup_subsys *ss, struct cgroup *cgrp)
 	return ret;
 }
 
-/* if the CSS is online, invoke ->pre_destory() on it and mark it offline */
+/* if the CSS is online, invoke ->css_offline() on it and mark it offline */
 static void offline_css(struct cgroup_subsys *ss, struct cgroup *cgrp)
-	__releases(&cgroup_mutex) __acquires(&cgroup_mutex)
 {
 	struct cgroup_subsys_state *css = cgrp->subsys[ss->subsys_id];
 
-- 
1.8.0.2

  parent reply	other threads:[~2013-07-31  8:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31  8:16 [PATCH 0/7] some pending cgroup patches Li Zefan
2013-07-31  8:16 ` [PATCH 1/7] cgroup: fix a leak when percpu_ref_init() fails Li Zefan
2013-07-31 10:14   ` Tejun Heo
2013-07-31  8:16 ` Li Zefan [this message]
2013-07-31 10:42   ` [PATCH 2/7] cgroup: remove sparse tags from offline_css() Tejun Heo
2013-07-31  8:17 ` [PATCH 3/7] cgroup: restructure the failure path in cgroup_write_event_control() Li Zefan
2013-07-31 10:44   ` Tejun Heo
2013-08-01  1:51     ` [PATCH v2 " Li Zefan
2013-08-01 13:30       ` Tejun Heo
2013-07-31  8:17 ` [PATCH 4/7] cgroup: rename cgroup_pidlist->mutex Li Zefan
2013-07-31 11:35   ` Tejun Heo
2013-08-01  1:52     ` [PATCH v2 " Li Zefan
2013-08-01 13:30       ` Tejun Heo
2013-07-31  8:17 ` [PATCH 5/7] cgroup: remove struct cgroup_seqfile_state Li Zefan
2013-07-31  9:27   ` Li Zefan
2013-07-31 11:35     ` Tejun Heo
2013-08-01  1:11       ` Li Zefan
2013-07-31  8:18 ` [PATCH 6/7] cgroup: rename current_css_set_cg_links Li Zefan
2013-07-31 11:38   ` Tejun Heo
2013-08-01  1:11     ` Li Zefan
2013-07-31  8:18 ` [PATCH 7/7] cgroup: more naming cleanups Li Zefan
2013-07-31 11:39   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F8C7E8.1080909@huawei.com \
    --to=lizefan@huawei.com \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox