From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource
Date: Wed, 31 Jul 2013 12:11:54 +0100 [thread overview]
Message-ID: <51F8F0FA.1050200@st.com> (raw)
In-Reply-To: <1375071776-29037-1-git-send-email-sachin.kamat@linaro.org>
On 29/07/13 05:22, Sachin Kamat wrote:
> devm_request_and_ioremap is deprecated. Use devm_ioremap_resource
> instead.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/pinctrl/pinctrl-st.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 04d4506..6246d7a 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1222,11 +1222,9 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
> if (of_address_to_resource(np, 0, &res))
> return -ENODEV;
>
> - bank->base = devm_request_and_ioremap(dev, &res);
> - if (!bank->base) {
> - dev_err(dev, "Can't get IO memory mapping!\n");
> - return -ENODEV;
> - }
> + bank->base = devm_ioremap_resource(dev, &res);
> + if (IS_ERR(bank->base))
> + return PTR_ERR(bank->base);
>
> bank->gpio_chip = st_gpio_template;
> bank->gpio_chip.base = bank_num * ST_GPIO_PINS_PER_BANK;
>
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
next prev parent reply other threads:[~2013-07-31 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 4:22 [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Sachin Kamat
2013-07-29 4:22 ` [PATCH 2/2] pinctrl: st: Staticize local symbols Sachin Kamat
2013-07-31 11:12 ` Srinivas KANDAGATLA
2013-08-07 18:54 ` Linus Walleij
2013-07-31 11:11 ` Srinivas KANDAGATLA [this message]
2013-08-07 18:52 ` [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8F0FA.1050200@st.com \
--to=srinivas.kandagatla@st.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox