* [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource
@ 2013-07-29 4:22 Sachin Kamat
2013-07-29 4:22 ` [PATCH 2/2] pinctrl: st: Staticize local symbols Sachin Kamat
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Sachin Kamat @ 2013-07-29 4:22 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, srinivas.kandagatla, sachin.kamat
devm_request_and_ioremap is deprecated. Use devm_ioremap_resource
instead.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-st.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 04d4506..6246d7a 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1222,11 +1222,9 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
if (of_address_to_resource(np, 0, &res))
return -ENODEV;
- bank->base = devm_request_and_ioremap(dev, &res);
- if (!bank->base) {
- dev_err(dev, "Can't get IO memory mapping!\n");
- return -ENODEV;
- }
+ bank->base = devm_ioremap_resource(dev, &res);
+ if (IS_ERR(bank->base))
+ return PTR_ERR(bank->base);
bank->gpio_chip = st_gpio_template;
bank->gpio_chip.base = bank_num * ST_GPIO_PINS_PER_BANK;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] pinctrl: st: Staticize local symbols 2013-07-29 4:22 [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Sachin Kamat @ 2013-07-29 4:22 ` Sachin Kamat 2013-07-31 11:12 ` Srinivas KANDAGATLA 2013-08-07 18:54 ` Linus Walleij 2013-07-31 11:11 ` [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Srinivas KANDAGATLA 2013-08-07 18:52 ` Linus Walleij 2 siblings, 2 replies; 6+ messages in thread From: Sachin Kamat @ 2013-07-29 4:22 UTC (permalink / raw) To: linux-kernel; +Cc: linus.walleij, srinivas.kandagatla, sachin.kamat Symbols used only in this file are made static. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/pinctrl/pinctrl-st.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 6246d7a..2a10a31 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -288,8 +288,8 @@ struct st_pinctrl { /* SOC specific data */ /* STiH415 data */ -unsigned int stih415_input_delays[] = {0, 500, 1000, 1500}; -unsigned int stih415_output_delays[] = {0, 1000, 2000, 3000}; +static unsigned int stih415_input_delays[] = {0, 500, 1000, 1500}; +static unsigned int stih415_output_delays[] = {0, 1000, 2000, 3000}; #define STIH415_PCTRL_COMMON_DATA \ .rt_style = st_retime_style_packed, \ @@ -324,7 +324,7 @@ static const struct st_pctl_data stih415_right_data = { }; /* STiH416 data */ -unsigned int stih416_delays[] = {0, 300, 500, 750, 1000, 1250, 1500, +static unsigned int stih416_delays[] = {0, 300, 500, 750, 1000, 1250, 1500, 1750, 2000, 2250, 2500, 2750, 3000, 3250 }; static const struct st_pctl_data stih416_data = { @@ -811,7 +811,7 @@ static int st_pmx_get_funcs_count(struct pinctrl_dev *pctldev) return info->nfunctions; } -const char *st_pmx_get_fname(struct pinctrl_dev *pctldev, +static const char *st_pmx_get_fname(struct pinctrl_dev *pctldev, unsigned selector) { struct st_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] pinctrl: st: Staticize local symbols 2013-07-29 4:22 ` [PATCH 2/2] pinctrl: st: Staticize local symbols Sachin Kamat @ 2013-07-31 11:12 ` Srinivas KANDAGATLA 2013-08-07 18:54 ` Linus Walleij 1 sibling, 0 replies; 6+ messages in thread From: Srinivas KANDAGATLA @ 2013-07-31 11:12 UTC (permalink / raw) To: Sachin Kamat; +Cc: linux-kernel, linus.walleij On 29/07/13 05:22, Sachin Kamat wrote: > Symbols used only in this file are made static. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/pinctrl/pinctrl-st.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 6246d7a..2a10a31 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -288,8 +288,8 @@ struct st_pinctrl { > > /* SOC specific data */ > /* STiH415 data */ > -unsigned int stih415_input_delays[] = {0, 500, 1000, 1500}; > -unsigned int stih415_output_delays[] = {0, 1000, 2000, 3000}; > +static unsigned int stih415_input_delays[] = {0, 500, 1000, 1500}; > +static unsigned int stih415_output_delays[] = {0, 1000, 2000, 3000}; > > #define STIH415_PCTRL_COMMON_DATA \ > .rt_style = st_retime_style_packed, \ > @@ -324,7 +324,7 @@ static const struct st_pctl_data stih415_right_data = { > }; > > /* STiH416 data */ > -unsigned int stih416_delays[] = {0, 300, 500, 750, 1000, 1250, 1500, > +static unsigned int stih416_delays[] = {0, 300, 500, 750, 1000, 1250, 1500, > 1750, 2000, 2250, 2500, 2750, 3000, 3250 }; > > static const struct st_pctl_data stih416_data = { > @@ -811,7 +811,7 @@ static int st_pmx_get_funcs_count(struct pinctrl_dev *pctldev) > return info->nfunctions; > } > > -const char *st_pmx_get_fname(struct pinctrl_dev *pctldev, > +static const char *st_pmx_get_fname(struct pinctrl_dev *pctldev, > unsigned selector) > { > struct st_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); > Acked-by: Srinivas Kandagatla <srinivas.kandagatla@st.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] pinctrl: st: Staticize local symbols 2013-07-29 4:22 ` [PATCH 2/2] pinctrl: st: Staticize local symbols Sachin Kamat 2013-07-31 11:12 ` Srinivas KANDAGATLA @ 2013-08-07 18:54 ` Linus Walleij 1 sibling, 0 replies; 6+ messages in thread From: Linus Walleij @ 2013-08-07 18:54 UTC (permalink / raw) To: Sachin Kamat; +Cc: linux-kernel@vger.kernel.org, Srinivas KANDAGATLA On Mon, Jul 29, 2013 at 6:22 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Symbols used only in this file are made static. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Patch applied with Srinivas ACK. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource 2013-07-29 4:22 [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Sachin Kamat 2013-07-29 4:22 ` [PATCH 2/2] pinctrl: st: Staticize local symbols Sachin Kamat @ 2013-07-31 11:11 ` Srinivas KANDAGATLA 2013-08-07 18:52 ` Linus Walleij 2 siblings, 0 replies; 6+ messages in thread From: Srinivas KANDAGATLA @ 2013-07-31 11:11 UTC (permalink / raw) To: Sachin Kamat; +Cc: linux-kernel, linus.walleij On 29/07/13 05:22, Sachin Kamat wrote: > devm_request_and_ioremap is deprecated. Use devm_ioremap_resource > instead. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/pinctrl/pinctrl-st.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 04d4506..6246d7a 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -1222,11 +1222,9 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info, > if (of_address_to_resource(np, 0, &res)) > return -ENODEV; > > - bank->base = devm_request_and_ioremap(dev, &res); > - if (!bank->base) { > - dev_err(dev, "Can't get IO memory mapping!\n"); > - return -ENODEV; > - } > + bank->base = devm_ioremap_resource(dev, &res); > + if (IS_ERR(bank->base)) > + return PTR_ERR(bank->base); > > bank->gpio_chip = st_gpio_template; > bank->gpio_chip.base = bank_num * ST_GPIO_PINS_PER_BANK; > Acked-by: Srinivas Kandagatla <srinivas.kandagatla@st.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource 2013-07-29 4:22 [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Sachin Kamat 2013-07-29 4:22 ` [PATCH 2/2] pinctrl: st: Staticize local symbols Sachin Kamat 2013-07-31 11:11 ` [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Srinivas KANDAGATLA @ 2013-08-07 18:52 ` Linus Walleij 2 siblings, 0 replies; 6+ messages in thread From: Linus Walleij @ 2013-08-07 18:52 UTC (permalink / raw) To: Sachin Kamat; +Cc: linux-kernel@vger.kernel.org, Srinivas KANDAGATLA On Mon, Jul 29, 2013 at 6:22 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > devm_request_and_ioremap is deprecated. Use devm_ioremap_resource > instead. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Applied with Srinivas ACK. Thanks! Linus Walleij ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-07 18:54 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-07-29 4:22 [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Sachin Kamat 2013-07-29 4:22 ` [PATCH 2/2] pinctrl: st: Staticize local symbols Sachin Kamat 2013-07-31 11:12 ` Srinivas KANDAGATLA 2013-08-07 18:54 ` Linus Walleij 2013-07-31 11:11 ` [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource Srinivas KANDAGATLA 2013-08-07 18:52 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox