Re: [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource

Srinivas KANDAGATLA
2013-07-31T11:23:16Z

On 29/07/13 05:22, Sachin Kamat wrote:
> devm_request_and_ioremap is deprecated. Use devm_ioremap_resource
> instead.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/pinctrl/pinctrl-st.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 04d4506..6246d7a 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1222,11 +1222,9 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
> if (of_address_to_resource(np, 0, &res))
> return -ENODEV;
>
> - bank->base = devm_request_and_ioremap(dev, &res);
> - if (!bank->base) {
> - dev_err(dev, "Can't get IO memory mapping!\n");
> - return -ENODEV;
> - }
> + bank->base = devm_ioremap_resource(dev, &res);
> + if (IS_ERR(bank->base))
> + return PTR_ERR(bank->base);
>
> bank->gpio_chip = st_gpio_template;
> bank->gpio_chip.base = bank_num * ST_GPIO_PINS_PER_BANK;
>
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>