From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Cc: swarren@wwwdotorg.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Mikko Perttunen <mperttunen@nvidia.com>
Subject: Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore
Date: Wed, 31 Jul 2013 22:18:55 +0400 [thread overview]
Message-ID: <51F9550F.3080503@cogentembedded.com> (raw)
In-Reply-To: <1375292543-7896-3-git-send-email-ttynkkynen@nvidia.com>
Hello.
On 07/31/2013 09:42 PM, Tuomas Tynkkynen wrote:
> From: Mikko Perttunen <mperttunen@nvidia.com>
> Device tree entries for the three EHCI controllers on Tegra114.
> Enables the the third controller (USB host) on Dalmore.
I would have done the board patch separately from the SoC one.
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
[...]
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> index abf6c40..2905145 100644
> --- a/arch/arm/boot/dts/tegra114.dtsi
> +++ b/arch/arm/boot/dts/tegra114.dtsi
> @@ -430,6 +430,68 @@
> status = "disable";
> };
>
> + usb@7d000000 {
> + compatible = "nvidia,tegra30-ehci", "usb-ehci";
> + reg = <0x7d000000 0x4000>;
> + interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
> + phy_type = "utmi";
> + clocks = <&tegra_car TEGRA114_CLK_USBD>;
> + nvidia,phy = <&phy1>;
> + status = "disabled";
> + };
> +
> + phy1: usb-phy@7d000000 {
At the same address as the previous node?
> + compatible = "nvidia,tegra30-usb-phy";
> + reg = <0x7d000000 0x4000 0x7d000000 0x4000>;
Hm, there must be some mistake: two similar register ranges.
> + usb@7d008000 {
> + compatible = "nvidia,tegra30-ehci", "usb-ehci";
> + reg = <0x7d008000 0x4000>;
> + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
> + phy_type = "utmi";
> + clocks = <&tegra_car TEGRA114_CLK_USB3>;
> + nvidia,phy = <&phy3>;
> + status = "disabled";
> + };
> +
> + phy3: usb-phy@7d008000 {
Again at the same address as previous node?
> + compatible = "nvidia,tegra30-usb-phy";
> + reg = <0x7d008000 0x4000 0x7d000000 0x4000>;
Second range conflicts with previous nodes.
WBR, Sergei
next prev parent reply other threads:[~2013-07-31 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 17:42 [PATCH 0/2] Device tree changes for Tegra30 and Tegra114 USB Host support Tuomas Tynkkynen
2013-07-31 17:42 ` [PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30 Tuomas Tynkkynen
2013-07-31 22:13 ` Stephen Warren
2013-08-01 15:15 ` Tuomas Tynkkynen
2013-07-31 17:42 ` [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore Tuomas Tynkkynen
2013-07-31 18:18 ` Sergei Shtylyov [this message]
2013-07-31 19:31 ` Tuomas Tynkkynen
2013-07-31 19:53 ` Sergei Shtylyov
2013-07-31 22:06 ` Stephen Warren
2013-07-31 22:20 ` Sergei Shtylyov
2013-07-31 23:29 ` Stephen Warren
2013-08-01 12:37 ` Sergei Shtylyov
2013-08-15 10:54 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F9550F.3080503@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=ttynkkynen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox