From: Brice Goglin <Brice.Goglin@inria.fr>
To: Dan Williams <djbw@fb.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: ioatdma: add ioat_raid_enabled module parameter
Date: Thu, 01 Aug 2013 00:05:51 +0200 [thread overview]
Message-ID: <51F98A3F.3000102@inria.fr> (raw)
ioatdma: add ioat_raid_enabled module parameter
Commit f26df1a1 added a 64-byte alignment requirement for legacy
operations to work around a silicon errata when mixing legacy and
RAID descriptors.
Passing ioat_raid_enabled=0 now disables RAID offload entirely in
the ioatdma driver so that legacy operations (memcpy, etc.) can
work without alignment restrictions anymore.
Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
---
drivers/dma/ioat/dma_v3.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
Index: b/drivers/dma/ioat/dma_v3.c
===================================================================
--- a/drivers/dma/ioat/dma_v3.c 2013-07-31 23:06:24.163810000 +0200
+++ b/drivers/dma/ioat/dma_v3.c 2013-07-31 23:47:54.246719841 +0200
@@ -67,6 +67,11 @@
#include "dma.h"
#include "dma_v2.h"
+static int ioat_raid_enabled = 1;
+module_param(ioat_raid_enabled, int, 0444);
+MODULE_PARM_DESC(ioat_raid_enabled,
+ "control support of RAID offload (default: 1)");
+
/* ioat hardware assumes at least two sources for raid operations */
#define src_cnt_to_sw(x) ((x) + 2)
#define src_cnt_to_hw(x) ((x) - 2)
@@ -1775,7 +1780,7 @@ int ioat3_dma_probe(struct ioatdma_devic
dma->device_alloc_chan_resources = ioat2_alloc_chan_resources;
dma->device_free_chan_resources = ioat2_free_chan_resources;
- if (is_xeon_cb32(pdev))
+ if (is_xeon_cb32(pdev) && ioat_raid_enabled)
dma->copy_align = 6;
dma_cap_set(DMA_INTERRUPT, dma->cap_mask);
@@ -1783,7 +1788,7 @@ int ioat3_dma_probe(struct ioatdma_devic
device->cap = readl(device->reg_base + IOAT_DMA_CAP_OFFSET);
- if (is_bwd_noraid(pdev))
+ if (!ioat_raid_enabled || is_bwd_noraid(pdev))
device->cap &= ~(IOAT_CAP_XOR | IOAT_CAP_PQ | IOAT_CAP_RAID16SS);
/* dca is incompatible with raid operations */
next reply other threads:[~2013-07-31 22:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 22:05 Brice Goglin [this message]
2013-07-31 22:14 ` ioatdma: add ioat_raid_enabled module parameter Jiang, Dave
2013-08-01 17:11 ` Jon Mason
2013-08-01 17:15 ` Jiang, Dave
2013-08-02 7:34 ` Brice Goglin
2013-08-02 16:14 ` Jiang, Dave
2013-08-02 16:57 ` Dan Williams
2013-08-02 17:08 ` Jiang, Dave
2013-08-02 17:26 ` Brice Goglin
2013-08-02 17:47 ` Dan Williams
2013-08-02 19:18 ` Brice Goglin
2013-08-12 18:10 ` Jon Mason
2013-08-12 18:13 ` Dan Williams
2013-08-02 18:01 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F98A3F.3000102@inria.fr \
--to=brice.goglin@inria.fr \
--cc=dave.jiang@intel.com \
--cc=djbw@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox