From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756499Ab3HAOgE (ORCPT ); Thu, 1 Aug 2013 10:36:04 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:44087 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755405Ab3HAOgB (ORCPT ); Thu, 1 Aug 2013 10:36:01 -0400 Message-ID: <51FA7255.1070102@cogentembedded.com> Date: Thu, 01 Aug 2013 18:36:05 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: linux-kernel@vger.kernel.org, "David S. Miller" , Roopa Prabhu , John Fastabend , Patrick McHardy , netdev@vger.kernel.org Subject: Re: [PATCH] macvlan: validate flags References: <1375353992-7181-1-git-send-email-mst@redhat.com> In-Reply-To: <1375353992-7181-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 01-08-2013 14:48, Michael S. Tsirkin wrote: > commit df8ef8f3aaa6692970a436204c4429210addb23a Please also specify that commit's summary line in parens. This is the only way to uniquely identify the commit, and it's the requirement that came originally from Linus AFAIK. > added a flags field to macvlan, which can be > controlled from userspace. > The idea is to make the interface future-proof > so we can add flags and not new fields. > However, flags value isn't validated, as a result, > userspace can't detect which flags are supported. > Cc: "David S. Miller" > CC: Roopa Prabhu > Cc: John Fastabend > Signed-off-by: Michael S. Tsirkin WBR, Sergei