From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: akpm@linux-foundation.org, grant.likely@linaro.org,
rob.herring@calxeda.com, rob@landley.net,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
gg@slimlogic.co.uk, kishon@ti.com, swarren@nvidia.com,
pawel.moll@arm.com, Mark.Rutland@arm.com,
ian.campbell@citrix.com, broonie@kernel.org
Subject: Re: [PATCH V2] drivers/rtc/rtc-palmas.c: support for backup battery charging
Date: Thu, 01 Aug 2013 10:44:06 -0600 [thread overview]
Message-ID: <51FA9056.7010104@wwwdotorg.org> (raw)
In-Reply-To: <1375367471-29908-1-git-send-email-ldewangan@nvidia.com>
On 08/01/2013 08:31 AM, Laxman Dewangan wrote:
> Palmas series device like TPS65913, TPS80036 supports the backup battery
> for powering the RTC when no other energy source is available.
>
> The backup battery is optional, connected to the VBACKUP pin, and can be
> nonrechargeable or rechargeable. The rechargeable battery can be charged
> from the system supply using the backup battery charger.
>
> Add support for enabling charging of this backup battery. Also add the DT
> binding document and the new properties to have this support.
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-palmas.txt b/Documentation/devicetree/bindings/rtc/rtc-palmas.txt
> +Palmas RTC controller bindings
> +
> +Required properties:
> +- compatible:
> + - "ti,palmas-rtc" for palma series of the RTC controller
Nit: Here is another Palma -vs- Palmas inconsistency. What is the
correct name for the device; Palma or Palmas? Either way, the should
always have an initial capital letter in free-form text (i.e. but not in
property/node names).
Aside from that, the binding looks fine to me now, assuming it's fully
describing the RTC module's functionality. So, the binding,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
prev parent reply other threads:[~2013-08-01 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 14:31 [PATCH V2] drivers/rtc/rtc-palmas.c: support for backup battery charging Laxman Dewangan
2013-08-01 15:09 ` Felipe Balbi
2013-08-01 15:33 ` Laxman Dewangan
2013-08-01 16:44 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FA9056.7010104@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Mark.Rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=kishon@ti.com \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox