From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Linux PM list <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
cpufreq@vger.kernel.org,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>
Subject: Re: [RFC][PATCH] cpufreq: Do not hold driver module references for additional policy CPUs
Date: Fri, 02 Aug 2013 00:31:23 +0530 [thread overview]
Message-ID: <51FAB083.5050900@linux.vnet.ibm.com> (raw)
In-Reply-To: <1656801.jLHjvytfNU@vostro.rjw.lan>
On 08/02/2013 12:31 AM, Rafael J. Wysocki wrote:
> On Thursday, August 01, 2013 11:36:49 PM Srivatsa S. Bhat wrote:
>> Its the cpufreq_cpu_get() hidden away in cpufreq_add_dev_symlink(). With
>> that taken care of, everything should be OK. Then we can change the
>> synchronization part to avoid using refcounts.
>
> So I actually don't see why cpufreq_add_dev_symlink() needs to call
> cpufreq_cpu_get() at all, since the policy refcount is already 1 at the
> point it is called and the bumping up of the driver module refcount is
> pointless.
>
Hmm, yes, it seems so.
> However, if I change that I also need to change the piece of code that
> calls the complementary cpufreq_cpu_put() and I kind of cannot find it.
>
... I guess that's because you are looking at the code with your patch
applied (and your patch removed that _put()) ;-)
Its this part in __cpufreq_remove_dev():
1303 } else {
1304
1305 if (!frozen) {
1306 pr_debug("%s: removing link, cpu: %d\n", __func__, cpu);
1307 cpufreq_cpu_put(data);
1308 }
1309
Regards,
Srivatsa S. Bhat
next prev parent reply other threads:[~2013-08-01 19:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 0:08 [RFC][PATCH] cpufreq: Do not hold driver module references for additional policy CPUs Rafael J. Wysocki
2013-08-01 8:11 ` Srivatsa S. Bhat
2013-08-01 14:44 ` Viresh Kumar
2013-08-01 15:24 ` Srivatsa S. Bhat
2013-08-01 17:24 ` Viresh Kumar
2013-08-01 18:09 ` Rafael J. Wysocki
2013-08-01 18:04 ` Rafael J. Wysocki
2013-08-01 18:06 ` Srivatsa S. Bhat
2013-08-01 19:01 ` Rafael J. Wysocki
2013-08-01 19:01 ` Srivatsa S. Bhat [this message]
2013-08-01 19:21 ` Rafael J. Wysocki
2013-08-01 19:21 ` Srivatsa S. Bhat
2013-08-01 20:04 ` Rafael J. Wysocki
2013-08-01 20:26 ` Srivatsa S. Bhat
2013-08-01 20:47 ` Rafael J. Wysocki
2013-08-01 20:53 ` [Update][PATCH] " Rafael J. Wysocki
2013-08-02 4:37 ` Viresh Kumar
2013-08-02 6:49 ` Srivatsa S. Bhat
2013-08-02 6:59 ` Viresh Kumar
2013-08-02 7:09 ` Srivatsa S. Bhat
2013-08-02 7:16 ` Viresh Kumar
2013-08-02 9:36 ` Viresh Kumar
2013-08-02 10:12 ` Srivatsa S. Bhat
2013-08-02 10:55 ` Viresh Kumar
2013-08-02 13:31 ` Rafael J. Wysocki
2013-08-02 14:38 ` Viresh Kumar
2013-08-02 14:46 ` Srivatsa S. Bhat
2013-08-02 10:30 ` Viresh Kumar
2013-08-02 11:35 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FAB083.5050900@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).