From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: <plagnioj@jcrosoft.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
<hector.palacios@digi.com>,
Thomas Petazzoni <thomas@free-electrons.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-fbdev@vger.kernel.org>
Subject: Re: [PATCHv3 1/3] video: mxsfb: fix color settings for 18bit data bus and 32bpp
Date: Fri, 2 Aug 2013 11:35:29 +0300 [thread overview]
Message-ID: <51FB6F51.7090500@ti.com> (raw)
In-Reply-To: <1375346437-18991-2-git-send-email-maxime.ripard@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
On 01/08/13 11:40, Maxime Ripard wrote:
> From: Hector Palacios <hector.palacios@digi.com>
>
> For a combination of 18bit LCD data bus width and a color
> mode of 32bpp, the driver was setting the color mapping to
> rgb666, which is wrong, as the color in memory realy has an
> rgb888 layout.
>
> This patch also removes the setting of flag CTRL_DF24 that
> makes the driver dimiss the upper 2 bits when handling 32/24bpp
> colors in a diplay with 18bit data bus width. This flag made
> true color images display wrong in such configurations.
>
> Finally, the color mapping rgb666 has also been removed as nobody
> is using it and high level applications like Qt5 cannot work
> with it either.
>
> Reference: https://lkml.org/lkml/2013/5/23/220
> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
> Acked-by: Juergen Beisert <jbe@pengutronix.de>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> drivers/video/mxsfb.c | 26 --------------------------
> 1 file changed, 26 deletions(-)
This one is labeled as "fix". Should it got to v3.11?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-08-02 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 8:40 [PATCHv3 0/3] Few ignored framebuffer fixes/additions Maxime Ripard
2013-08-01 8:40 ` [PATCHv3 1/3] video: mxsfb: fix color settings for 18bit data bus and 32bpp Maxime Ripard
2013-08-02 8:35 ` Tomi Valkeinen [this message]
2013-08-02 9:19 ` Maxime Ripard
2013-08-01 8:40 ` [PATCHv3 2/3] video: hx8357: Make IM pins optional Maxime Ripard
2013-08-01 8:40 ` [PATCHv3 3/3] fb: backlight: HX8357: Add HX8369 support Maxime Ripard
2013-08-01 12:39 ` Tomi Valkeinen
2013-08-02 8:28 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FB6F51.7090500@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=hector.palacios@digi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=plagnioj@jcrosoft.com \
--cc=thomas@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox