From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758343Ab3HBJ2e (ORCPT ); Fri, 2 Aug 2013 05:28:34 -0400 Received: from mail-we0-f179.google.com ([74.125.82.179]:64839 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758078Ab3HBJ2c (ORCPT ); Fri, 2 Aug 2013 05:28:32 -0400 Message-ID: <51FB7BB6.1010606@gmail.com> Date: Fri, 02 Aug 2013 11:28:22 +0200 From: Richard Genoud User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130704 Icedove/17.0.7 MIME-Version: 1.0 To: boris brezillon CC: Nicolas Ferre , Jean-Christophe Plagniol-Villard , Ludovic Desroches , Russell King , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/8] ARM: at91/dt: make use of periph id macros References: <1375339733-3488-1-git-send-email-b.brezillon@overkiz.com> <51FB7634.3080302@overkiz.com> In-Reply-To: <51FB7634.3080302@overkiz.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2013 11:04, boris brezillon wrote: > Hello Richard, > > On 01/08/2013 09:37, Richard Genoud wrote: >> 2013/8/1 Boris BREZILLON : >>> Hello, >>> >>> This patch series move at91 SoCs peripheral id definitions from machine >>> specific include dir to dt-bindings include dir. >>> These macros are used to reference interrupts instead of peripheral >>> numbers. >>> >>> This makes dt definitions cleaner and easier to debug (one can easily >>> tell if >>> the peripheral macro used to reference an interrupt line is not the >>> good one). >>> >>> These macros will be used for clk definitions and references too. >>> >>> I am not sure 'include/dt-bindings/at91/xxx' is the best place to put >>> these >>> definitions as there are no soc specific directories in dt-bindings >>> include >>> dir right now. Maybe something like >>> 'include/dt-bindings/soc/at91/xxx' or >>> 'include/dt-bindings/peripherals/at91/xxx' would be better. >>> What do you think ? >> Well, I'd rather use "atmel" than "at91" because, AFAIK, this prefix >> has been dropped for new atmel SoCs (sama5 for instance). > > Should I do the same for at91 clk series (replace drivers/clk/at91 > directory > by drivers/clk/atmel and include/linux/clk/at91_pmc.h by > include/linux/clk/atmel_pmc.h) ? I would say so, but like you said, that needs atmel maintainer's feedback !