From: Henk de Groot <henk.de.groot@hetnet.nl>
To: Evan Ng <evan.sin.ng@gmail.com>
Cc: pe1dnn@amsat.org, gregkh@linuxfoundation.org,
johanmeiring@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool
Date: Sun, 04 Aug 2013 17:43:09 +0200 [thread overview]
Message-ID: <51FE768D.1030506@hetnet.nl> (raw)
In-Reply-To: <20130802193909.GA5405@gmail.com>
Hello Evan,
When reformatting the array containing the firmware data it may be easier
to use 8 bytes per row. It is currently it is 16 bytes per row
(overrunning the 80 characters/line) and this just means cutting each row
exactly in half. In your first proposal it was completely reformatted to
an odd 11 bytes per row which makes comparison with the original during
review much harder and it is also easier to make mistakes.
Kind regards,
Henk.
prev parent reply other threads:[~2013-08-04 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1375303465-3437-1-git-send-email-evan.sin.ng@gmail.com>
2013-08-01 21:50 ` [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool Greg KH
[not found] ` <CAGkkOHezKfjYaGJHcbPPiE4EobOLMp=K62-NWhpbvp2QDhLOfA@mail.gmail.com>
2013-08-01 22:28 ` Greg KH
2013-08-01 23:48 ` Joe Perches
2013-08-02 10:37 ` Dan Carpenter
2013-08-02 19:39 ` Evan Ng
2013-08-04 15:43 ` Henk de Groot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FE768D.1030506@hetnet.nl \
--to=henk.de.groot@hetnet.nl \
--cc=devel@driverdev.osuosl.org \
--cc=evan.sin.ng@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johanmeiring@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pe1dnn@amsat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox