From: Alexey Khoroshilov <khoroshilov@ispras.ru>
To: Joe Perches <joe@perches.com>
Cc: Jouni Malinen <j@w1.fi>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] hostap: do not return positive number on failure path in prism2_open()
Date: Mon, 05 Aug 2013 08:01:08 +0400 [thread overview]
Message-ID: <51FF2384.2070008@ispras.ru> (raw)
In-Reply-To: <1375673616.3133.23.camel@joe-AO722>
On 08/05/2013 07:33 AM, Joe Perches wrote:
> On Mon, 2013-08-05 at 07:18 +0400, Alexey Khoroshilov wrote:
>> prism2_open() as an .ndo_open handler should not return positive numbers
>> in case of failure, but it does return 1 in a couple of places.
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
> How?
>
> http://linuxtesting.org/project/ldv
> http://linuxtesting.org/results/ldv
>
> Shows defects and patches to fix them, but not any script
> used to find it.
There is a link to build instructions there:
http://forge.ispras.ru/projects/ldv/wiki/Downloading_and_Building_LDV
Currently it requires some efforts to install all the dependencies, the
simplest way is to use puppet script for Ubuntu 12.04 that you can find
in the repository.
--
Alexey
next prev parent reply other threads:[~2013-08-05 4:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 3:18 [PATCH] hostap: do not return positive number on failure path in prism2_open() Alexey Khoroshilov
2013-08-05 3:33 ` Joe Perches
2013-08-05 4:01 ` Alexey Khoroshilov [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-05 3:02 Alexey Khoroshilov
2013-08-05 3:18 ` Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FF2384.2070008@ispras.ru \
--to=khoroshilov@ispras.ru \
--cc=j@w1.fi \
--cc=joe@perches.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox