From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Hyeoncheol Lee <cheol.lee@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Oleg Nesterov <oleg@redhat.com>,
"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH 04/13] tracing/kprobes: Factor out struct trace_probe
Date: Mon, 05 Aug 2013 15:00:25 +0900 [thread overview]
Message-ID: <51FF3F79.6090202@hitachi.com> (raw)
In-Reply-To: <1375261410-11219-5-git-send-email-namhyung@kernel.org>
(2013/07/31 18:03), Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> There are functions that can be shared to both of kprobes and uprobes.
> Separate common data structure to struct trace_probe and use it from
> the shared functions.
Thanks, basically I'm good at this change.
Could you also rename several functions which handles trace_kprobe
instead of trace_probe? (as you did on trace_probe_XXX())
e.g.
> @@ -107,14 +91,14 @@ static int kretprobe_dispatcher(struct kretprobe_instance *ri,
> /*
> * Allocate new trace_probe and initialize it (including kprobes).
> */
> -static struct trace_probe *alloc_trace_probe(const char *group,
> +static struct trace_kprobe *alloc_trace_probe(const char *group,
Now this allocates trace_kprobe instead of trace_probe, so
this should be called as alloc_trace_kprobe().
Below functions should also be renamed.
> -static void free_trace_probe(struct trace_probe *tp)
> +static void free_trace_probe(struct trace_kprobe *tp)
> -static struct trace_probe *find_trace_probe(const char *event,
> - const char *group)
> +static struct trace_kprobe *find_trace_probe(const char *event,
> + const char *group)
> -enable_trace_probe(struct trace_probe *tp, struct ftrace_event_file *file)
> +enable_trace_probe(struct trace_kprobe *tp, struct ftrace_event_file *file)
> -disable_trace_probe(struct trace_probe *tp, struct ftrace_event_file *file)
> +disable_trace_probe(struct trace_kprobe *tp, struct ftrace_event_file *file)
> /* Internal register function - just handle k*probes and flags */
> -static int __register_trace_probe(struct trace_probe *tp)
> +static int __register_trace_probe(struct trace_kprobe *tp)
> /* Internal unregister function - just handle k*probes and flags */
> -static void __unregister_trace_probe(struct trace_probe *tp)
> +static void __unregister_trace_probe(struct trace_kprobe *tp)
For below two, comments should be updated too.
> /* Unregister a trace_probe and probe_event: call with locking probe_lock */
> -static int unregister_trace_probe(struct trace_probe *tp)
> +static int unregister_trace_probe(struct trace_kprobe *tp)
> /* Register a trace_probe and probe_event */
> -static int register_trace_probe(struct trace_probe *tp)
> +static int register_trace_probe(struct trace_kprobe *tp)
> @@ -399,7 +383,7 @@ static int trace_probe_module_callback(struct notifier_block *nb,
> unsigned long val, void *data)
> @@ -448,7 +432,7 @@ static int create_trace_probe(int argc, char **argv)
> static int release_all_trace_probes(void)
> static struct ftrace_event_file *
> -find_trace_probe_file(struct trace_probe *tp, struct trace_array *tr)
> +find_trace_probe_file(struct trace_kprobe *tp, struct trace_array *tr)
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2013-08-05 6:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 9:03 [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v2) Namhyung Kim
2013-07-31 9:03 ` [PATCH 01/13] tracing/kprobes: Move fetch functions to trace_kprobe.c Namhyung Kim
2013-08-05 5:30 ` Masami Hiramatsu
2013-08-05 8:44 ` Namhyung Kim
2013-07-31 9:03 ` [PATCH 02/13] tracing/kprobes: Add fetch{,_size} member into symbol and deref fetch method Namhyung Kim
2013-08-05 8:19 ` Masami Hiramatsu
2013-08-05 8:58 ` Namhyung Kim
2013-07-31 9:03 ` [PATCH 03/13] tracing/kprobes: Make stack and memory fetch functions static Namhyung Kim
2013-08-05 9:04 ` Masami Hiramatsu
2013-08-09 7:35 ` Namhyung Kim
2013-08-09 9:15 ` Masami Hiramatsu
2013-07-31 9:03 ` [PATCH 04/13] tracing/kprobes: Factor out struct trace_probe Namhyung Kim
2013-08-05 6:00 ` Masami Hiramatsu [this message]
2013-08-05 8:49 ` Namhyung Kim
2013-07-31 9:03 ` [PATCH 05/13] tracing/uprobes: Convert to " Namhyung Kim
2013-07-31 9:03 ` [PATCH 06/13] tracing/kprobes: Move common functions to trace_probe.c Namhyung Kim
2013-08-05 6:03 ` Masami Hiramatsu
2013-08-05 8:50 ` Namhyung Kim
2013-07-31 9:03 ` [PATCH 07/13] tracing/kprobes: Remove duplicate set_print_fmt() Namhyung Kim
2013-08-05 6:46 ` Masami Hiramatsu
2013-07-31 9:03 ` [PATCH 08/13] tracing/uprobes: Fetch args before reserving a ring buffer Namhyung Kim
2013-07-31 9:03 ` [PATCH 09/13] tracing/uprobes: Fix a comment for uprobe registration syntax Namhyung Kim
2013-08-05 5:59 ` Masami Hiramatsu
2013-08-05 8:47 ` Namhyung Kim
2013-07-31 9:03 ` [PATCH 10/13] tracing/kprobes: Add priv argument to fetch functions Namhyung Kim
2013-07-31 9:03 ` [PATCH 11/13] tracing/uprobes: Add more " Namhyung Kim
2013-07-31 9:03 ` [PATCH 12/13] tracing/uprobes: Add support for full argument access methods Namhyung Kim
2013-07-31 9:03 ` [PATCH 13/13] tracing/probes: Fix basic print type functions Namhyung Kim
2013-08-05 6:22 ` Masami Hiramatsu
2013-08-05 6:31 ` Joe Perches
2013-08-05 7:27 ` Masami Hiramatsu
2013-08-05 8:55 ` Namhyung Kim
2013-08-05 8:51 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FF3F79.6090202@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=acme@ghostprotocols.net \
--cc=cheol.lee@lge.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox