From: Rupesh Gujare <rupesh.gujare@atmel.com>
To: Anca Emanuel <anca.emanuel@gmail.com>
Cc: <devel@linuxdriverproject.org>,
Wu Fengguang <fengguang.wu@intel.com>,
<linux-usb@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: ozwpan: Fix build warning.
Date: Mon, 5 Aug 2013 11:03:55 +0100 [thread overview]
Message-ID: <51FF788B.6060804@atmel.com> (raw)
In-Reply-To: <CAJL_dMvs3-r+cKxNzG=i=TczwXwbcie0B+UbU7ykQ2K6aDu3+Q@mail.gmail.com>
On 04/08/13 19:17, Anca Emanuel wrote:
> Why do not use div_u64() ?
>
> [quote]unsigned 64bit divide with 32bit divisor
>
> This is the most common 64bit divide and should be used if possible,
> as many 32bit archs can optimize this variant better than a full 64bit
> divide.
> [/quote]
>
>> - ep->credit += timespec_to_ns(&delta) / NSEC_PER_MSEC;
>> + ep->credit += div64_u64(timespec_to_ns(&delta), NSEC_PER_MSEC);
Thank you Anca.
I will resend the patch.
--
Regards,
Rupesh Gujare
next prev parent reply other threads:[~2013-08-05 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-04 17:43 [PATCH] staging: ozwpan: Fix build warning Rupesh Gujare
2013-08-04 18:17 ` Anca Emanuel
2013-08-05 10:03 ` Rupesh Gujare [this message]
2013-08-05 11:14 ` [PATCH v2] " Rupesh Gujare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FF788B.6060804@atmel.com \
--to=rupesh.gujare@atmel.com \
--cc=anca.emanuel@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox