From: Juergen Gross <jgross@suse.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>
Cc: "Ostrovsky, Boris" <boris.ostrovsky@oracle.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"Torvalds, Linus" <torvalds@linux-foundation.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"kys@microsoft.com" <kys@microsoft.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"lists@nerdbynature.de" <lists@nerdbynature.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"Lutomirski, Andy" <luto@kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"Cui, Dexuan" <decui@microsoft.com>,
"mikelley@microsoft.com" <mikelley@microsoft.com>,
"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR
Date: Wed, 15 Feb 2023 09:25:13 +0100 [thread overview]
Message-ID: <51a67208-3374-bbd9-69be-650d515c519f@suse.com> (raw)
In-Reply-To: <cb98f918fbc8b58e0a8d6823b4f92ad1d4265cfe.camel@intel.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 861 bytes --]
On 13.02.23 19:21, Edgecombe, Rick P wrote:
> On Mon, 2023-02-13 at 07:12 +0100, Juergen Gross wrote:
>>
>> Thanks for the report.
>>
>> I'll have a look. Probably I'll need to re-add the check for WB in
>> patch 7.
>
> Sure, let me know if you need any more details about by setup.
I have reproduced the issue.
Adding back the test for WB will fix it, but I'm not sure this is really
what I should do.
The problem arises in case a large mapping is spanning multiple MTRRs,
even if they define the same caching type (uniform is set to 0 in this
case).
So the basic question for me is: shouldn't the semantics of uniform be
adpated? Today it means "the range is covered by only one MTRR or by
none". Looking at the use cases I'm wondering whether it shouldn't be
"the whole range has the same caching type".
Thoughts?
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2023-02-15 8:25 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 7:22 [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR Juergen Gross
2023-02-09 7:22 ` [PATCH v2 1/8] x86/mtrr: split off physical address size calculation Juergen Gross
2023-02-11 10:08 ` Borislav Petkov
2023-02-13 6:19 ` Juergen Gross
2023-02-09 7:22 ` [PATCH v2 2/8] x86/mtrr: support setting MTRR state for software defined MTRRs Juergen Gross
2023-02-13 1:07 ` Michael Kelley (LINUX)
2023-02-13 6:27 ` Juergen Gross
2023-02-13 6:43 ` Michael Kelley (LINUX)
2023-02-13 11:39 ` Borislav Petkov
2023-02-13 14:07 ` Juergen Gross
2023-02-13 15:03 ` Borislav Petkov
2023-02-13 15:11 ` Borislav Petkov
2023-02-13 15:18 ` Juergen Gross
2023-02-13 15:40 ` Borislav Petkov
2023-02-13 15:44 ` Juergen Gross
2023-02-13 18:53 ` Borislav Petkov
2023-02-14 7:04 ` Juergen Gross
2023-02-14 8:58 ` Borislav Petkov
2023-02-14 9:02 ` Juergen Gross
2023-02-14 9:10 ` Borislav Petkov
2023-02-14 9:17 ` Juergen Gross
2023-02-14 9:32 ` Borislav Petkov
2023-02-13 15:27 ` Dave Hansen
2023-02-13 15:38 ` Juergen Gross
2023-02-13 15:36 ` Juergen Gross
2023-02-13 18:43 ` Borislav Petkov
2023-02-14 7:01 ` Juergen Gross
2023-02-14 0:45 ` Kirill A. Shutemov
2023-02-16 9:32 ` Juergen Gross
2023-02-16 11:02 ` Jeremi Piotrowski
2023-02-16 11:25 ` Borislav Petkov
2023-02-16 12:19 ` Juergen Gross
2023-02-16 12:29 ` Borislav Petkov
2023-02-16 16:04 ` Michael Kelley (LINUX)
2023-02-16 11:07 ` Jeremi Piotrowski
2023-02-16 11:27 ` Borislav Petkov
2023-02-09 7:22 ` [PATCH v2 3/8] x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest Juergen Gross
2023-02-13 1:07 ` Michael Kelley (LINUX)
2023-02-13 6:28 ` Juergen Gross
2023-02-09 7:22 ` [PATCH v2 4/8] x86/xen: set MTRR state when running as Xen PV initial domain Juergen Gross
2023-02-09 7:22 ` [PATCH v2 5/8] x86/mtrr: revert commit 90b926e68f50 Juergen Gross
2023-02-10 18:59 ` Linux regression tracking (Thorsten Leemhuis)
2023-02-13 6:07 ` Juergen Gross
2023-02-13 11:46 ` Christian Kujau
2023-02-13 16:23 ` Juergen Gross
2023-02-13 17:01 ` Michael Kelley (LINUX)
2023-02-13 17:24 ` Juergen Gross
2023-02-13 22:54 ` Christian Kujau
2023-02-14 7:13 ` Juergen Gross
2023-02-09 7:22 ` [PATCH v2 6/8] x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID Juergen Gross
2023-02-09 7:22 ` [PATCH v2 7/8] x86/mm: only check uniform after calling mtrr_type_lookup() Juergen Gross
2023-02-11 0:06 ` Edgecombe, Rick P
2023-02-13 6:08 ` Juergen Gross
2023-02-13 1:08 ` Michael Kelley (LINUX)
2023-02-13 6:35 ` Juergen Gross
2023-02-15 13:40 ` Juergen Gross
2023-02-15 19:38 ` Michael Kelley (LINUX)
2023-02-16 5:22 ` Juergen Gross
2023-02-09 7:22 ` [PATCH v2 8/8] x86/mtrr: drop sanity check in mtrr_type_lookup_fixed() Juergen Gross
2023-02-11 0:06 ` [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR Edgecombe, Rick P
2023-02-13 6:12 ` Juergen Gross
2023-02-13 18:21 ` Edgecombe, Rick P
2023-02-15 8:25 ` Juergen Gross [this message]
2023-02-15 23:22 ` Linus Torvalds
2023-02-16 5:35 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51a67208-3374-bbd9-69be-650d515c519f@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=luto@kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox