From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B6AE3A5995 for ; Wed, 10 Jun 2026 08:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781079269; cv=none; b=fXWdU1bBqjAch+ZGme3W6e0CS6PaNfeMoppRIIm7EWbooP27z39VovcZH4y0MQVICkJk92r+XfKDkQ3r14v/xtGQtW20yKq3asSt5i+omhGrXyoB2Q10OkqGcyr09pVs0NJ8bbBAFr9wiz8Kw4ubxbl5dUvl0+4kEgwfQQSE/mM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781079269; c=relaxed/simple; bh=6tNt2knlQaGLvQLbDqwVIf8lCHEl1tWiYmIoI7brRqk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pj4qJqccVJ53nY4UsDAXB62s0pmbR+BMZYp2u7uNl+xxXv3Z4ivOCab1DW4K2ozbuNuot0bMVwgLySLAj/3itByeOIptybxoSnH5HdKPR/VwtQPbFSzkOwHl6LNKxyaJGhvh0h4qbaAi5j7zzC1Z3VUnrlJ6hBHQ0MJ23j7sCZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Nvq1PM6E; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K0lDtIG3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Nvq1PM6E"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K0lDtIG3" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A7hj5o530216 for ; Wed, 10 Jun 2026 08:14:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P7m2AaYtiFBNkE7Ec+ikzutKgjTULANhgT2ImDwCS9o=; b=Nvq1PM6Ejt8MJoeh AueWOCR44Q3IkI3Gc0gy++O+cqpj0O3EFom9YQTiPrUxrEp3ARC03U4brbsezgU6 H4YC7CXcsBGXwAMMKVOA8oP21A4yqHnPcss2k8nSYJaKFMlCH6Rqv9qQItAdhey4 9Z1ABoTkfVlLvvj0JnQL7dJSww0PYbts0g60HNRtSYtEZWHnTGK5fQEAEtkjpLgj jYMfZGbd3STrr/BCa8E81qHA0Rk+IwRSCVIeZ1qICw9lE4ZMimkmgKqjdp+wZaui nZI64FfQ0JHVbS+A7D/zAAx6FJ6xkreMX3Cqv14oxlORlv4/vkTWScYeM0yyPp5E IcEYJw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epwr2he2a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 08:14:27 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c0c32f4b1bso67037425ad.2 for ; Wed, 10 Jun 2026 01:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781079267; x=1781684067; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P7m2AaYtiFBNkE7Ec+ikzutKgjTULANhgT2ImDwCS9o=; b=K0lDtIG3F8xmMNJWmusaF5rloUcmCXwWhPsRM5c1atp2rGNqyjuU9ENOugEj7Ou2tG JHZDe7+ZR/B4JdQ3+3y+phelrplwV56DH9pJtP2OmMJEwqAKgNHyfNJzBlBntkJCN7YM OvXH6loPzr8tkxR9djLCcgvp0/lY5SwIJxUOFUw4qbZMF7e4nlNE9M0gL7lttdiIKBvp 5xZmR1fIDfYtAZzY7VjQ7pvx/c5+XC52lGWliFw7AElLAlcYo8e/AZC9z7GtzBRfZvNM CInJx1EpsXU87PyRN6RAfZPSFG6r+TZ1k0GpTEK4BcWKvDyRXbQRsCbu+DfDF261LPJE EiuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781079267; x=1781684067; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P7m2AaYtiFBNkE7Ec+ikzutKgjTULANhgT2ImDwCS9o=; b=qhqM9mDz2PQmiUYtpYAcYjL6hbQb/4KswaoOj9UJs88KrRBIllH2gqD31VkwGvmh/P pzwQ7BYWbMvuGhH5qK++u2Gix/M+plwHS+j111K5gsqQyKF2AScND2ljVftdcYfE2YUL zRAZh33lYUoKEtEJQ5F6hXB+8iFe/Ok/dHeVLvtvI387BuNjaPk3pf8dI9yoaGuSv0r2 hu/kNkopLbvH/H7gFHseXWfQTZlFyP9Wj5uhNnueT8H5B15GiOfY0wmwKgigyD/TC1Tk 9bmAGJyBuxOLuVbGL28wvGcPjSLOD4LiDoYm3BxDG7W2KEkbhTLUFhgFjBfNlZ9tCZ5w fn2g== X-Forwarded-Encrypted: i=1; AFNElJ/UvjLSAZY9wq0CPYecAIBluQbCXK02IFX7Brh1wX4yLWwCv+NmE/sDZgynLJtZNdIOcEyGdRZt1Gz9T5c=@vger.kernel.org X-Gm-Message-State: AOJu0YzCaQOcOuOAhMETd1F4iaJJICNhCr2o15+CNZp1tUaQ8rUH3SvH 3qxkL3SywBJr55ni3cogF1BYPwFNyCAO9ohNlkvK9b/kHAvoywEfIXnUKVCr1HbhUhx5vK4Rwlj 2vklAsCzjFgbR6d7FRe/gEYTNuOADNriURCpsFKQzQkUaHjQ1aRXR3YfVdNAE4kBhO+w= X-Gm-Gg: Acq92OH1bGOe7VoAV9SNywXdYeTL+PL2HJGFJJxAAx40IOsLBoAdzIzL2qIgQjWRehg mgljZqHIwrMegTeoEh5gwzY/N0YcgBVop+DmA3APZeQ3f/LW+730FI9PADBFZBa0hE8etwiXZrR ac5cgqPb2eQgNz+Mn3ZkG/tr6VqfXJGSQzWQvQXMMzZ9IyoO4IvjHrMlnuZd75W6ziGbKb4S/Zu TRHCHbH6SPQapMUk9Z7imu8ARmvQwRBZWdNld+dVZiRybX9iW1os26hktn8TGCD5q6RItiu0Gbk z3brXc5W6n3eHvo9tVGmCA3ibsuJKujziG1iAV3qkEeqKsm5Rqbp95W39m149GY8p5VOnmZx9oZ j2q83XzKuoCKdBdYBwiHk8OeShNPszp1YMjctwLpNAR28yQblX+ebnhlRD5jI X-Received: by 2002:a17:902:e892:b0:2bd:ba44:6c07 with SMTP id d9443c01a7336-2c1e7b3273cmr272141045ad.16.1781079266979; Wed, 10 Jun 2026 01:14:26 -0700 (PDT) X-Received: by 2002:a17:902:e892:b0:2bd:ba44:6c07 with SMTP id d9443c01a7336-2c1e7b3273cmr272140575ad.16.1781079266399; Wed, 10 Jun 2026 01:14:26 -0700 (PDT) Received: from [10.218.18.193] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d389sm227967235ad.16.2026.06.10.01.14.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 01:14:26 -0700 (PDT) Message-ID: <51b95f5a-d123-441d-832e-be023fb9d98d@oss.qualcomm.com> Date: Wed, 10 Jun 2026 13:44:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM To: Nathan Chancellor , Linus Walleij Cc: Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com, Konrad Dybcio References: <20260522204644.4101640-1-ajay.nandam@oss.qualcomm.com> <20260522204644.4101640-3-ajay.nandam@oss.qualcomm.com> <20260609231238.GA1901681@ax162> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: <20260609231238.GA1901681@ax162> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Gu1yPE1C c=1 sm=1 tr=0 ts=6a291ce3 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=I1y84f6UziIZZygAmgMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDA3NyBTYWx0ZWRfX/BF+R7FYyrK+ sDSWLwhbPEuuderenP0A49Fu+qX5h3+oZsddcMLSOcEtllIpJc2oMPf/SQhedygw0vB4uSwFYWJ qr4us/m2lqWCLPTe/tnfxGlUUXr22D2RhavCoICx6k2AL6bR+Ip99Z6/LPXbmy/1SKzJiWjxYhN 2BYZxIIXX5VIc2K943c15zlRghChlCqFk+vpUo+oKTE+97Puczw9Q7IdE/QBRiTU5AQTocpnRRV 9BKjvtU/kKSmJjDZU+lWO2G1yfScnvuI0nOHwMKLLHceWYLT+coayFg+sA21tXVhY+9DoUOyH2v ReqiHO214AJrMzNTjmYN8jktEvZVuNY6SdrUARotvoJGQL4F1rXNoPRDydiRe0GMIJttkwB9I7T i7Ry4o6kkSeWhcizEllwm2dRBcn3eJ57BA4MbwC7JmBB0aZbugqx26eEcHhAVzCEtpWppF/DR1D wmhl+vsGHJ1KcheU3uA== X-Proofpoint-ORIG-GUID: AXGXPKqyhEEorPFYXzYMlYI3LJTQam6Z X-Proofpoint-GUID: AXGXPKqyhEEorPFYXzYMlYI3LJTQam6Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 adultscore=0 clxscore=1015 spamscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100077 On 6/10/2026 4:42 AM, Nathan Chancellor wrote: > Hi Ajay, > > On Sat, May 23, 2026 at 02:16:44AM +0530, Ajay Kumar Nandam wrote: > ... >> diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> index 15ced5027579..4d758fd117c4 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > ... >> @@ -48,22 +49,48 @@ static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int pin, >> else >> pin_offset = LPI_TLMM_REG_OFFSET * pin; >> >> - return ioread32(state->tlmm_base + pin_offset + addr); >> + return state->tlmm_base + pin_offset + addr; >> +} >> + >> +static void __lpi_gpio_read(struct lpi_pinctrl *state, >> + unsigned int pin, unsigned int addr, u32 *val) >> +{ >> + *val = ioread32(lpi_gpio_reg(state, pin, addr)); >> +} >> + >> +static void __lpi_gpio_write(struct lpi_pinctrl *state, >> + unsigned int pin, unsigned int addr, >> + unsigned int val) >> +{ >> + iowrite32(val, lpi_gpio_reg(state, pin, addr)); >> +} >> + >> +static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int pin, >> + unsigned int addr, u32 *val) >> +{ >> + int ret; >> + >> + ret = pm_runtime_resume_and_get(state->dev); >> + if (ret < 0) >> + return ret; >> + >> + __lpi_gpio_read(state, pin, addr, val); >> + >> + return pm_runtime_put_autosuspend(state->dev); >> } >> >> static int lpi_gpio_write(struct lpi_pinctrl *state, unsigned int pin, >> unsigned int addr, unsigned int val) >> { >> - u32 pin_offset; >> + int ret; >> >> - if (state->data->flags & LPI_FLAG_USE_PREDEFINED_PIN_OFFSET) >> - pin_offset = state->data->groups[pin].pin_offset; >> - else >> - pin_offset = LPI_TLMM_REG_OFFSET * pin; >> + ret = pm_runtime_resume_and_get(state->dev); >> + if (ret < 0) >> + return ret; >> >> - iowrite32(val, state->tlmm_base + pin_offset + addr); >> + __lpi_gpio_write(state, pin, addr, val); >> >> - return 0; >> + return pm_runtime_put_autosuspend(state->dev); >> } >> >> static const struct pinctrl_ops lpi_gpio_pinctrl_ops = { > > After this change landed in -next as commit b719ede389d8 ("pinctrl: > qcom: lpass-lpi: Switch to PM clock framework for runtime PM"), there is > a warning that lpi_gpio_write() is completely unused, breaking the > build: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:82:12: error: 'lpi_gpio_write' defined but not used [-Werror=unused-function] > 82 | static int lpi_gpio_write(struct lpi_pinctrl *state, unsigned int pin, > | ^~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Seems legitimate, is this intended? > > $ rg lpi_gpio_write drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > 61:static void __lpi_gpio_write(struct lpi_pinctrl *state, > 82:static int lpi_gpio_write(struct lpi_pinctrl *state, unsigned int pin, > 91: __lpi_gpio_write(state, pin, addr, val); > 167: __lpi_gpio_write(pctrl, group, > 172: __lpi_gpio_write(pctrl, group, > 179: __lpi_gpio_write(pctrl, pin, LPI_GPIO_CFG_REG, val); > 340: __lpi_gpio_write(pctrl, group, LPI_GPIO_VALUE_REG, val); > 350: __lpi_gpio_write(pctrl, group, LPI_GPIO_CFG_REG, val); Hi Nathan, Thanks for catching this. You're right — lpi_gpio_write() became unused after the runtime PM refactor, which triggers -Wunused-function with W=1/Werror builds. I’ve sent a follow-up fix to remove the unused helper: https://lore.kernel.org/all/20260610080809.2588640-1-ajay.nandam@oss.qualcomm.com/ Thanks again for the report and testing. >