From: Todd Brandt <todd.e.brandt@linux.intel.com>
To: john.ogness@linutronix.de, pmladek@suse.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
senozhatsky@chromium.org, rostedt@goodmis.org
Subject: Re: PNP0501 serial driver takes almost 2 seconds to suspend/resume (printk issue)
Date: Thu, 07 Jul 2022 13:45:17 -0700 [thread overview]
Message-ID: <51b9e2cc3baf61a604bd239b736ec2d12f1f6695.camel@linux.intel.com> (raw)
In-Reply-To: <12fb98fe27e23e3f74a139e5e8eb83a97a343372.camel@linux.intel.com>
Adding printk maintainers to the thread
On Thu, 2022-07-07 at 13:31 -0700, Todd Brandt wrote:
> Ever since 5.19.0-rc1 the serial device has taken almost a second
> longer in both suspend and resume. This effect is witnessed in half
> the
> machines in our lab (~10 machines). It occurs on dell, asus, gigabyte
> and other machines so it's not hardware specific.
>
> I opened a bugzilla issue which includes the git bisect:
> https://bugzilla.kernel.org/show_bug.cgi?id=216216
>
>
> Bad commit:
>
> commit 3b604ca81202eea2a917eb6491e90f610fba0ec7
> Author: John Ogness <john.ogness@linutronix.de>
> Date: Thu Apr 21 23:28:46 2022 +0206
>
> printk: add pr_flush()
>
> Provide a might-sleep function to allow waiting for console
> printers
> to catch up to the latest logged message.
>
> Use pr_flush() whenever it is desirable to get buffered messages
> printed before continuing: suspend_console(), resume_console(),
> console_stop(), console_start(), console_unblank().
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Petr Mladek <pmladek@suse.com>
> Link:
>
https://lore.kernel.org/r/20220421212250.565456-12-john.ogness@linutronix.de
>
> include/linux/printk.h | 7 +++++
> kernel/printk/printk.c | 83
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 90 insertions(+)
next prev parent reply other threads:[~2022-07-07 20:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 20:31 PNP0501 serial driver takes almost 2 seconds to suspend/resume (printk issue) Todd Brandt
2022-07-07 20:45 ` Todd Brandt [this message]
2022-07-08 8:01 ` John Ogness
2022-07-08 21:35 ` Todd Brandt
2022-07-09 20:41 ` John Ogness
2022-07-10 19:39 ` Andy Shevchenko
2022-07-10 20:04 ` John Ogness
2022-07-11 8:13 ` Petr Mladek
2022-07-11 10:10 ` Sergey Senozhatsky
2022-07-13 9:51 ` John Ogness
2022-07-13 14:24 ` Todd Brandt
2022-07-13 17:11 ` Todd Brandt
2022-07-13 18:23 ` Todd Brandt
2022-07-13 21:22 ` John Ogness
2022-07-13 22:01 ` John Ogness
2022-07-14 22:16 ` Todd Brandt
2022-07-15 6:14 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51b9e2cc3baf61a604bd239b736ec2d12f1f6695.camel@linux.intel.com \
--to=todd.e.brandt@linux.intel.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox