From: linmiaohe <linmiaohe@huawei.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
"johannes.berg@intel.com" <johannes.berg@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] netlink: remove duplicated nla_need_padding_for_64bit() check
Date: Mon, 24 Aug 2020 11:58:24 +0000 [thread overview]
Message-ID: <51bd2b4c5f4549488de08bdcf6daae23@huawei.com> (raw)
friendly ping :)
>Miaohe Lin <linmiaohe@huawei.com> wrote:
>From: Miaohe Lin <linmiaohe@huawei.com>
>
>The need for padding 64bit is implicitly checked by nla_align_64bit(), so remove this explicit one.
>
>Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>---
> lib/nlattr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/lib/nlattr.c b/lib/nlattr.c index bc5b5cf608c4..98f596bfbfd8 100644
>--- a/lib/nlattr.c
>+++ b/lib/nlattr.c
>@@ -816,8 +816,7 @@ EXPORT_SYMBOL(__nla_reserve); struct nlattr *__nla_reserve_64bit(struct sk_buff *skb, int attrtype,
> int attrlen, int padattr)
> {
>- if (nla_need_padding_for_64bit(skb))
>- nla_align_64bit(skb, padattr);
>+ nla_align_64bit(skb, padattr);
>
> return __nla_reserve(skb, attrtype, attrlen); }
>--
>2.19.1
>
next reply other threads:[~2020-08-24 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 11:58 linmiaohe [this message]
2020-08-24 13:41 ` [PATCH] netlink: remove duplicated nla_need_padding_for_64bit() check David Miller
-- strict thread matches above, loose matches on Subject: below --
2020-08-01 9:45 linmiaohe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51bd2b4c5f4549488de08bdcf6daae23@huawei.com \
--to=linmiaohe@huawei.com \
--cc=davem@davemloft.net \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox