From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
Jerry Snitselaar <jsnitsel@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christian Bundy <christianbundy@fraction.io>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
stable <stable@vger.kernel.org>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core_init
Date: Tue, 17 Dec 2019 03:25:01 +0200 [thread overview]
Message-ID: <51dcaf500c7f081ccebf3386884e7f4826d83075.camel@linux.intel.com> (raw)
In-Reply-To: <CAPcyv4jUz9X-eyf7M78dfS-7pzi4Xqs+LdpUSD=eoeQjd1kxug@mail.gmail.com>
On Wed, 2019-12-11 at 18:18 -0800, Dan Williams wrote:
> On Wed, Dec 11, 2019 at 6:15 PM Dan Williams <dan.j.williams@intel.com> wrote:
> > On Wed, Dec 11, 2019 at 3:56 PM Jerry Snitselaar <jsnitsel@redhat.com> wrote:
> > > Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when
> > > issuing commands to the tpm during initialization, just reserve the
> > > chip after wait_startup, and release it when we are ready to call
> > > tpm_chip_register.
> > >
> > > Cc: Christian Bundy <christianbundy@fraction.io>
> > > Cc: Dan Williams <dan.j.williams@intel.com>
> > > Cc: Peter Huewe <peterhuewe@gmx.de>
> > > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > > Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
> > > Cc: stable@vger.kernel.org
> > > Cc: linux-integrity@vger.kernel.org
> > > Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
> > > Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's")
> >
> > Ugh, sorry, I guess this jinxed it. This patch does not address the
> > IRQ storm on the platform I reported earlier.
>
> Are the reverts making their way upstream?
Not yet.
Cannot randomly apply patches without answer to why. Given that
some changes are already landed changes it would be better to
create a patch based on reverts (in the sense of code change)
and commit message what is going on.
/Jarkko
next prev parent reply other threads:[~2019-12-17 1:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 23:17 [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core_init Jerry Snitselaar
2019-12-11 23:26 ` Jerry Snitselaar
2019-12-11 23:30 ` Dan Williams
2019-12-11 23:49 ` Jerry Snitselaar
2019-12-11 23:54 ` [PATCH v2] " Jerry Snitselaar
2019-12-12 2:15 ` Dan Williams
2019-12-12 2:18 ` Dan Williams
2019-12-17 1:25 ` Jarkko Sakkinen [this message]
2019-12-17 0:58 ` Jarkko Sakkinen
2019-12-17 1:18 ` Dan Williams
2019-12-17 2:00 ` Jerry Snitselaar
2019-12-17 2:14 ` Dan Williams
2019-12-17 12:05 ` Jarkko Sakkinen
2019-12-17 17:18 ` Jerry Snitselaar
2019-12-17 17:26 ` Jerry Snitselaar
2019-12-18 23:09 ` Jarkko Sakkinen
2019-12-18 23:06 ` Jarkko Sakkinen
2019-12-18 23:31 ` Dan Williams
2019-12-19 10:07 ` Jerry Snitselaar
2019-12-27 5:09 ` Jarkko Sakkinen
2019-12-27 5:42 ` Jarkko Sakkinen
2019-12-27 6:03 ` Jarkko Sakkinen
2019-12-17 20:29 ` Jerry Snitselaar
2019-12-18 23:12 ` Jarkko Sakkinen
2019-12-17 1:19 ` Jarkko Sakkinen
2019-12-17 0:43 ` [PATCH] " Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51dcaf500c7f081ccebf3386884e7f4826d83075.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=christianbundy@fraction.io \
--cc=dan.j.williams@intel.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox