From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753535AbdJHVOb (ORCPT ); Sun, 8 Oct 2017 17:14:31 -0400 Received: from mail-dm3nam03on0040.outbound.protection.outlook.com ([104.47.41.40]:50976 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753347AbdJHVO2 (ORCPT ); Sun, 8 Oct 2017 17:14:28 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v5 11/31] crypto: ccp: Define SEV key management command id To: Borislav Petkov References: <20171004131412.13038-1-brijesh.singh@amd.com> <20171004131412.13038-12-brijesh.singh@amd.com> <20171005205658.77onrn2mr2mrxafs@pd.tnic> From: Brijesh Singh Message-ID: <51e390d6-724a-dec1-91b7-4af20c73b08b@amd.com> Date: Sun, 8 Oct 2017 16:14:21 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171005205658.77onrn2mr2mrxafs@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: MWHPR15CA0044.namprd15.prod.outlook.com (10.173.226.158) To BY2PR12MB0146.namprd12.prod.outlook.com (10.162.82.19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 178c1f01-4f89-4236-b863-08d50e918e70 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:BY2PR12MB0146; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0146;3:cZ9W8zCcv7kIPixVLmKryEfngUEEhi3FKUch/cBbNMfkjrZ8siZFPYncF9WC+eUhOW6PX5dYVnhYCco+mmddpZrqLfFZVWPTk9vmNRCiysIMER6Vtap5J/wrPMM/cUVb4lXExBf8aOgp4LrvlMASQyd4fDJpbA3pnU5jNm0CJEr5DSKwigb296BVRuKpAPp1Z1Rh3SmsXqqZ2TrubKOJBgNj9PK6XQG+uBACVj+TJuJJdbJjuMzPagM23BRgfyqI;25:F/dGBqibflqzH3j1GYs5G3OckseipGYtTXLdKM/FsK+lfPOiqckTzY6hq2bHpaURBZQxVQrG+FXwN/ERv2Vik4S2W05LVlrl0x67bZHkL/OXZvFTUbvd4NWdEi0sntoscmjgQaKDkDLzRQU9IDGFsVKwBHrUVoOCmozLgbZWTVlBymAoK+d7XggGSLcQu4UPAaSXI6NigVwP0SICEEMVJk113L5ZUaS8m7Idxc4JHxHl1i6lRS0TD9NPje67rIlJpspURPEYsXAuzI803pt1jxmwb96S/YLcMvkwzE+iAOH/PbqblbmwMmG35QQm9wmarYd4yMia2FdBBbTPP2+QQA==;31:6t3iGCHIcekA6T9uSco8tcKgIbwamCIrwe0Ff4h1XM5/KedGUwlFntBP+Zd6EVjEdo9R4e6rcdoUjiYObtEXJKxghp6weGQDBAjUdb3p5yzEBbgjoNqQ1jFYT0VOSuX3RWGlKyW4SYbwHG/cNImBnCj+U5KB6bK7RIldEo4Ab7DODelGKbHFAe65hYtkNwG2DahuIREisdrs4aqj00wBliVuRlZFJCMlSwi5Cy/MBeE= X-MS-TrafficTypeDiagnostic: BY2PR12MB0146: X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0146;20:HkxWmmy2WBc9s5LJhN9na0S9kzH0bJSZZXTyy56OtzUa7ZV6fgKmy/AVE307x4Ng3252mnluYhhTszyjWYaMBWB6RQVxBs8xY/4FrvnO7/PP56DQGuihzPs2pkFUaq63jOqQ0XbGLKUfss6mU9Q7OTCRHPu3NTh16my3vOlmrEBRemEROsHi3tMeguDDMFlosL6CfgMZctd9rYESkKP87A+coJ8pNSYRIN6NCzBKbcQ+Uynr1dqMDLsjmdFqUvJIz800ZyXXhT1u3RwjEelRgqKpdUJDjvlhlOl8UOo62HDUNc2JFq9m2feR4rQitjahZuTrhgKq2rixR1+BDtbqSmHsX5CAYGoILR0WdGifw3hpJWV0CDEZ9urIPMAJCxpu+moTabonTXYUDOEbu3ERxnTguXgpVMjFYOSdRxI1IQiks/WufLbVsxFzn43i/4amSrfktWQnkeu2YT+tyjYzUkyiSOc3XE6ifWmL3y0nfmCq4v/yKnTsAMBFhp/NKc2z;4:2sxLjs2Nofs+e/SxNbBv7U5VXJbet0n0Z2LfFOL0Amf8FPgRAHuZBm9Q3UMVSe3XIcZLd/tmWoLr5asli4xqgCpGh4Iwt1ps3sB62uzDiKsp2X26AF45YAjk4gapAmcprkg5e2zLEWwvkMOUzsdMQXCPGGd+naceKw9RSzXtIeW+qEnT0GoUveqbx5WayQGvHDDIa6WjCfEeW6Jqk0FV6xLgyVpGIftVMX/EdF8hCieWRc++0k8e2OO/cDqmrwckuGFcbkx3moEpMwAffkV8/DbHJXaPFRL17AqbGhXB2gvGPSIo20WG5OH9lGyXKRQJ X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR12MB0146;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR12MB0146; X-Forefront-PRVS: 0454444834 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(376002)(346002)(24454002)(199003)(377454003)(189002)(53546010)(86362001)(229853002)(6246003)(58126008)(65826007)(50466002)(6506006)(6486002)(53936002)(101416001)(3846002)(50986999)(54356999)(33646002)(316002)(6116002)(106356001)(36756003)(4326008)(6512007)(16526018)(5660300001)(1720100001)(25786009)(966005)(189998001)(6306002)(68736007)(64126003)(2950100002)(97736004)(6916009)(54906003)(65806001)(31686004)(47776003)(478600001)(8936002)(76176999)(83506001)(2906002)(31696002)(2870700001)(105586002)(23676002)(305945005)(6666003)(65956001)(7736002)(8676002)(81166006)(66066001)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0146;H:Brijeshs-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjEyTUIwMTQ2OzIzOmdXUHBpMitrSzB1eUJKcVhSOTY1dE5sZVZ3?= =?utf-8?B?UUR1OHEyWllPdkpFRFVUQnRlUmJuNUhuQW1ldzVXODRUaWhiMVRNb2tzK2RZ?= =?utf-8?B?VWZqQkVzeDc1V2JiL3RvdnJGNTkzYUthSjZoeFRLazVFN2dlTUhLVGR2dWZ5?= =?utf-8?B?dzhvczl4RGNqUWJOdURWQ1hwcDVYS3k2MXNZZ2g5OTRYeGFubEZNK3ZPQjJt?= =?utf-8?B?N0pqRnVIbHp5U1lnakNzeWVRNWlJck9kbE0xVVcrU1BWbHRwUEl0Vi9SOXk4?= =?utf-8?B?QXJ1b25aaWh4N3FoZVBNZlhqNjIybUxyZDAyOUlnTjRpOGpNeGQ3cng4UmxJ?= =?utf-8?B?WVkvL0txYld1RkZaQ3MrLy9xY04zbUNWVFlVY0lLb3RkUkZLUHRuZ3ZsdEU2?= =?utf-8?B?YUNZa0dUQ3pkOXJnZW9pRG5UT3hoZzlEMjJHZzdlWC8wQ2hqaDB3TTJ3aGM1?= =?utf-8?B?Y04xUVp3eUlsdEI3cjN3S2dxTlRpNE9zTmRpM21idkNOOHo5TmI1SHFZOHcy?= =?utf-8?B?TWtoUTJ3ZTVNankzcEJyeWFON28wVitWaEcyYzIvT3AvYndFM3pxQlhvUEY3?= =?utf-8?B?T3E5akQ0NTlzZnArVjh6aDBWcmJCVW41bWZVRGtvOUozZFl3Ync4ekYwZW9U?= =?utf-8?B?a2Q3K2hrbTVqTXpvdEtYMnJKUTZyQ251MUNUVkxIaGo0d1dDYXpBSndOS3Yv?= =?utf-8?B?bUl5VHcyMkY1cTJwMXE4N25qczdBeCs3Nk5CUGMwZVRKWUdEd2tZbjJKQnJa?= =?utf-8?B?RWlwN29ZYTdoaUM1YXdCSWp2TFQ0Qks0STZjSVhuWG9hYVA1WHJCUHNsVjIv?= =?utf-8?B?d2JKVHlUaHI2VE52L0doN2o5c0ZjWFYwRURvNmFTV0FybXNPeVNHVG9UekNV?= =?utf-8?B?ZlBMcm9OQml0VG5TSVNYYk1ZNVRldjl5VEdRTGVnNlVxYnVKVjd2VG12eW0r?= =?utf-8?B?UUdBOFl4VmlxZExhQnBSWHd6M3RKeHBWVkJFRjl2cjQvbjl2bk83bm1KZS9F?= =?utf-8?B?T25kNlR4Y3kyTWYyYmZtN0F3N2xTNXJzVGgydXpBbHZIcHFjbEZObGhGcHhW?= =?utf-8?B?SFIyclFzS292aFFJTmR5NEQxbDZKRjhKSjFyUmY5NEJiS05FZzdINnVMSVg0?= =?utf-8?B?ZWVTb04yREh6ZHdrV2lYUk1RVGNoTDB4dC8yemlWeFZtUE1BU08zb1VZL2JJ?= =?utf-8?B?SUF3cGUvR2x4V0JNN0xqQlQ1a28vSjZaSzVvZVVIYTdSQ3N3KzZ5dldJdVpF?= =?utf-8?B?WjVpTmFhK2RlMDNFOFpLMk11SDVkbHRnQ29scFlqbHlYRG5tWFlwWlBYYUw4?= =?utf-8?B?b1lWVXdlMHhzRlkwUjM4dmNDL29BcTk4OFVpRml4dE90RHA2QzhRRTdCa0ZN?= =?utf-8?B?M3BUcy9sUTBXcmljbTRQWDc3MTJENHZ3b1JXcHNRemQzb1V4MFhWbXVuRXdE?= =?utf-8?B?Q3paZkJQY3BMdDd2U29nemJ2Y2tTUlZPYUV2WjhlWnhiOGsrSTVGVDRic25B?= =?utf-8?B?eUFaR1Y0RDVBWlhQSzN2Zy9aWGpIVTlkVXNPeXRtY3NWaVJTekNOQ01qQmx3?= =?utf-8?B?ZWtSVENlU1Z2TCtNaHozUytaWDZIblRKVnE4cDVRR1NGQmNoVUEzUkNKRDhM?= =?utf-8?B?RG1IaFJMZmdmdmE5eDY1dXdhc2tSYzFqTXU3Rjk5eGxOVFhKYmhLT0EwejJZ?= =?utf-8?B?Z1ZsdGtGRWE3ek1KZzdvb3NnYkNzeUZKZHMxVXJIMGlXcE1OeU9KSllqdm1C?= =?utf-8?B?anpmNDVNTzQ3dDFQRXNFenlucEowYitKWW5FaWZKSWcxd1FvMjk1enQyRHhr?= =?utf-8?B?UG9HVGZjYUdTRXZXaHFPSk5pRi85VGVRRXR1c2xnUXl4SU4zYUhTM2J5ejVL?= =?utf-8?B?V1BPbkJabWY3czZIM24weE9lM3d1TVhkS1RoUzdIUE5nMnhtanAvTkVYeGNW?= =?utf-8?B?bUZQVXAwQ013PT0=?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0146;6:vXLJ4ViPr2G3DDe9HiUiECDU2y5uzohCHQTighuoEhWoNTp+7wUFvTWQDbumOTdo9LvjjwnQxtMrvvRReuQBsUFXUyFJ4SS8LOPdfsrkwfm6G94xa77GpG84Wr7sQqAWjWCpvqjnGsktN1mjUPxjWbU9aSwPZiIu9YT3KunIkGzE6bugOzhNcZpKdwGg2DKmIxOxncoetKOG80co9gjfnc6jUUxUQQ9LDKrDk+GmOpAC/vrcJguRw1+qlEgslWf2LTY90apvc324ce7g5eavHUydmbaH/tyo175flVJbLX334GbVndM9Vf8cPMLOWJsu2Deqid3lllT8vKPAksN7sw==;5:uqIu/nDVbUn4DoXrzYm2YcyHbZh0iXShOaQPG+C2O12J+az9CwX0gHCotVaOv0u3UvBJX/rHb4T+iwmy7GPQunEaiN5OjH0leiodPwhabEmy2cvkIaKgs34XTN7mKcvWbTX5sU6pRhWPJryMvlkQsA==;24:UQHEuuxawpkD3y5gAc79KKlHNEwl4Pefjqo4QwRHWAvpcEYX7H6d6tIWTtdYzAF3FuS7juefwi7OlYgoyvq7RDQTIrhn9i+OOz5e1jF0byY=;7:5AgGUmJDr+i8qwt6u7LXPhCHYchyLQxmIePuV3hRHiNYTu688Z7tpBu+thlKHfKDLAPbTW56KLvIzdKiMGsPa5cxT/KkENC6fcQ9T3Xho4dEvdeVK06jiPtvXELCEiyGWvGEK5YuhQ5vJ/maEAdB5sT4i1NNYieYXXpfMz1IJyzz8RXJdJuOHNXELqObYEKxR+YscAWp8WFUL9arOS5C5oU41bB1SeH2FVEdPVY6gIA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0146;20:HITEoYalRKgoUdSxfaOvtI5+dZIO8WLznSnRXpYtxLUDcpcmnd1BOlKaKtR06Tgq0MAXIwj0xdBSZHFonaqQm8y+/YF0pCQVpIHuKTKgcmGqCQpABQUQscfbU4P2jAgFe2/0bNqt2UjgfxiG5fiqU8vDDSwRgXRptIiYTTd8JnlgWSgzwNCckXGMiPONzY+kL90Y7cQHyQO3rQ6i5/rfhAUus9N0dlLuvi4Fp8FxCmNK+t+tHGgP2QNe4xLbSmYb X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2017 21:14:25.1216 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0146 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/5/17 3:56 PM, Borislav Petkov wrote: > On Wed, Oct 04, 2017 at 08:13:52AM -0500, Brijesh Singh wrote: >> Define Secure Encrypted Virtualization (SEV) key management command id >> and structure. The command definition is available in SEV KM [1] spec >> 0.14. >> >> [1] http://support.amd.com/TechDocs/55766_SEV-KM API_Specification.pdf >> >> Cc: Paolo Bonzini >> Cc: "Radim Krčmář" >> Cc: Borislav Petkov >> Cc: Herbert Xu >> Cc: Gary Hook >> Cc: Tom Lendacky >> Cc: linux-crypto@vger.kernel.org >> Cc: kvm@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Brijesh Singh >> --- >> include/linux/psp-sev.h | 515 ++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 515 insertions(+) >> create mode 100644 include/linux/psp-sev.h > Some fixes ontop below. > > With that: > > Reviewed-by: Borislav Petkov Thanks, I have applied your fixes.