From: Krzysztof Kozlowski <krzk@kernel.org>
To: 郑豪威 <zhenghaowei@loongson.cn>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
chenhuacai@kernel.org, kernel@xen0n.name, p.zabel@pengutronix.de,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, loongarch@lists.linux.dev
Subject: Re: [PATCH v3 3/3] LoongArch: Update dts to support Loongson UART driver.
Date: Mon, 26 Aug 2024 10:18:21 +0200 [thread overview]
Message-ID: <51f564ea-9507-40b4-a943-23bdd330e6d6@kernel.org> (raw)
In-Reply-To: <fb0ddbe0-8613-40ac-a3fb-9e544c50088d@loongson.cn>
On 26/08/2024 08:54, 郑豪威 wrote:
>
> 在 2024/8/26 14:00, Krzysztof Kozlowski 写道:
>> On Mon, Aug 26, 2024 at 10:47:05AM +0800,zhenghaowei@loongson.cn wrote:
>>> From: Haowei Zheng<zhenghaowei@loongson.cn>
>>>
>>> Change to use the Loongson UART driver for Loongson-2K2000,
>>> Loongson-2K1000 and Loongson-2K0500.
>> Why?
>>
>> That's what commit msg should explain. This is not bisectable and
>> breaks users without any reasonable need/explanation.
>>
>> Best regards,
>> Krzysztof
>
> I got it, and I will provide detailed explanations like this:
>
> We have provided separate UART drivers for ls2k0500, ls2k1000, and
>
> ls2k2000, which solves the issue of the full-featured serial port being
>
> unusable. Additionally, we have implemented fractional division
>
> functionality for ls2k2000.
You still break the users. Explain the problem you are fixing. NAK.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-08-26 8:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 2:47 [PATCH v3 0/3] uart: Introduce uart driver for the Loongson family chips zhenghaowei
2024-08-26 2:47 ` [PATCH v3 1/3] dt-bindings: serial: Add Loongson UART controller zhenghaowei
2024-08-26 5:59 ` Krzysztof Kozlowski
2024-08-26 6:54 ` 郑豪威
2024-08-26 8:17 ` Krzysztof Kozlowski
2024-08-26 2:47 ` [PATCH v3 2/3] tty: serial: 8250: Add loongson uart driver support zhenghaowei
2024-08-26 2:47 ` [PATCH v3 3/3] LoongArch: Update dts to support Loongson UART driver zhenghaowei
2024-08-26 6:00 ` Krzysztof Kozlowski
2024-08-26 6:54 ` 郑豪威
2024-08-26 8:18 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51f564ea-9507-40b4-a943-23bdd330e6d6@kernel.org \
--to=krzk@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=zhenghaowei@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox