* [PATCH] kexec: remove unnecessary return
@ 2013-08-06 8:05 Xishi Qiu
2013-08-06 8:19 ` Zhang Yanfei
0 siblings, 1 reply; 3+ messages in thread
From: Xishi Qiu @ 2013-08-06 8:05 UTC (permalink / raw)
To: ebiederm; +Cc: kexec, LKML, Xishi Qiu
Code can not run here forever, so remove the unnecessary return.
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
kernel/kexec.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 59f7b55..c14e3ea 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1477,8 +1477,6 @@ static int __init __parse_crashkernel(char *cmdline,
else
return parse_crashkernel_simple(ck_cmdline, crash_size,
crash_base);
-
- return 0;
}
/*
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kexec: remove unnecessary return
2013-08-06 8:05 [PATCH] kexec: remove unnecessary return Xishi Qiu
@ 2013-08-06 8:19 ` Zhang Yanfei
0 siblings, 0 replies; 3+ messages in thread
From: Zhang Yanfei @ 2013-08-06 8:19 UTC (permalink / raw)
To: Xishi Qiu; +Cc: ebiederm, kexec, LKML
于 2013/8/6 16:05, Xishi Qiu 写道:
> Code can not run here forever, so remove the unnecessary return.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
> kernel/kexec.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 59f7b55..c14e3ea 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1477,8 +1477,6 @@ static int __init __parse_crashkernel(char *cmdline,
> else
> return parse_crashkernel_simple(ck_cmdline, crash_size,
> crash_base);
> -
> - return 0;
> }
>
> /*
>
Hi Xishi,
change
1474 if (first_colon && (!first_space || first_colon < first_space))
1475 return parse_crashkernel_mem(ck_cmdline, system_ram,
1476 crash_size, crash_base);
1477 else
1478 return parse_crashkernel_simple(ck_cmdline, crash_size,
1479 crash_base);
1480
1481 return 0;
to
1474 if (first_colon && (!first_space || first_colon < first_space))
1475 return parse_crashkernel_mem(ck_cmdline, system_ram,
1476 crash_size, crash_base);
1478 return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
seems better.
--
Thanks.
Zhang Yanfei
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] kexec: remove unnecessary return
@ 2013-08-07 8:45 Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2013-08-07 8:45 UTC (permalink / raw)
To: Andrew Morton, Eric W. Biederman
Cc: kexec, linux-kernel, Zhang Yanfei, Xishi Qiu, Simon Horman
From: Xishi Qiu <qiuxishi@huawei.com>
Code can not run here forever, so remove the unnecessary return.
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
Suggested-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
kernel/kexec.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Andrew, could you consider picking up this patch?
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 59f7b55..2a74f30 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline,
if (first_colon && (!first_space || first_colon < first_space))
return parse_crashkernel_mem(ck_cmdline, system_ram,
crash_size, crash_base);
- else
- return parse_crashkernel_simple(ck_cmdline, crash_size,
- crash_base);
- return 0;
+ return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
}
/*
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-07 8:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-06 8:05 [PATCH] kexec: remove unnecessary return Xishi Qiu
2013-08-06 8:19 ` Zhang Yanfei
-- strict thread matches above, loose matches on Subject: below --
2013-08-07 8:45 Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox