* [PATCH V2] kexec: remove unnecessary return
@ 2013-08-06 8:35 Xishi Qiu
2013-08-06 8:39 ` Simon Horman
2013-08-06 8:44 ` Zhang Yanfei
0 siblings, 2 replies; 3+ messages in thread
From: Xishi Qiu @ 2013-08-06 8:35 UTC (permalink / raw)
To: zhangyanfei, ebiederm; +Cc: kexec, LKML, Xishi Qiu
Code can not run here forever, so remove the unnecessary return.
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
Suggested-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
kernel/kexec.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 59f7b55..2a74f30 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline,
if (first_colon && (!first_space || first_colon < first_space))
return parse_crashkernel_mem(ck_cmdline, system_ram,
crash_size, crash_base);
- else
- return parse_crashkernel_simple(ck_cmdline, crash_size,
- crash_base);
- return 0;
+ return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
}
/*
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] kexec: remove unnecessary return
2013-08-06 8:35 [PATCH V2] kexec: remove unnecessary return Xishi Qiu
@ 2013-08-06 8:39 ` Simon Horman
2013-08-06 8:44 ` Zhang Yanfei
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2013-08-06 8:39 UTC (permalink / raw)
To: Xishi Qiu; +Cc: zhangyanfei, ebiederm, kexec, LKML
On Tue, Aug 06, 2013 at 04:35:00PM +0800, Xishi Qiu wrote:
> Code can not run here forever, so remove the unnecessary return.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> Suggested-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Reviewed-by: Simon Horman <horms@verge.net.au>
> ---
> kernel/kexec.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 59f7b55..2a74f30 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline,
> if (first_colon && (!first_space || first_colon < first_space))
> return parse_crashkernel_mem(ck_cmdline, system_ram,
> crash_size, crash_base);
> - else
> - return parse_crashkernel_simple(ck_cmdline, crash_size,
> - crash_base);
>
> - return 0;
> + return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
> }
>
> /*
> --
> 1.7.1
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] kexec: remove unnecessary return
2013-08-06 8:35 [PATCH V2] kexec: remove unnecessary return Xishi Qiu
2013-08-06 8:39 ` Simon Horman
@ 2013-08-06 8:44 ` Zhang Yanfei
1 sibling, 0 replies; 3+ messages in thread
From: Zhang Yanfei @ 2013-08-06 8:44 UTC (permalink / raw)
To: Xishi Qiu; +Cc: ebiederm, kexec, LKML
于 2013/8/6 16:35, Xishi Qiu 写道:
> Code can not run here forever, so remove the unnecessary return.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> Suggested-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
> ---
> kernel/kexec.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 59f7b55..2a74f30 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline,
> if (first_colon && (!first_space || first_colon < first_space))
> return parse_crashkernel_mem(ck_cmdline, system_ram,
> crash_size, crash_base);
> - else
> - return parse_crashkernel_simple(ck_cmdline, crash_size,
> - crash_base);
>
> - return 0;
> + return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
> }
>
> /*
>
--
Thanks.
Zhang Yanfei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-06 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-06 8:35 [PATCH V2] kexec: remove unnecessary return Xishi Qiu
2013-08-06 8:39 ` Simon Horman
2013-08-06 8:44 ` Zhang Yanfei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox