From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Cc: "balbi@ti.com" <balbi@ti.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Subject: Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support
Date: Tue, 06 Aug 2013 23:27:11 +0400 [thread overview]
Message-ID: <52014E0F.10404@cogentembedded.com> (raw)
In-Reply-To: <52014B89.9040106@nvidia.com>
Hello.
On 08/06/2013 11:16 PM, Tuomas Tynkkynen wrote:
> [...]
>>> + match = of_match_device(tegra_ehci_of_match, &pdev->dev);
>>> + if (!match) {
>>> + dev_err(&pdev->dev, "Error: No device match found\n");
>>> + return -ENODEV;
>>> + }
>>> + soc_config = (struct tegra_ehci_soc_config *)match->data;
>> Aren't casts from 'const void *' automatic?
>> WBR, Sergei
> Indeed they are, but those explicit casts seem to be used in many places in the kernel.
I suspect people just don't know C well enough. They are also being
gradually removed.
WBR, Sergei
next prev parent reply other threads:[~2013-08-06 19:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 18:08 [PATCH v2 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 1/6] usb: host: add has_tdi_phy_lpm capability bit Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 2/6] usb: phy: tegra: Fix wrong PHY parameters Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 3/6] usb: phy: tegra: Tegra30 support Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 4/6] Documentation: New DT parameters for tegra30-usb-phy Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 5/6] usb: phy: tegra: Program new PHY parameters Tuomas Tynkkynen
2013-08-06 18:08 ` [PATCH v2 6/6] usb: host: tegra: Tegra30 support Tuomas Tynkkynen
2013-08-06 18:35 ` Sergei Shtylyov
2013-08-06 19:16 ` Tuomas Tynkkynen
2013-08-06 19:27 ` Sergei Shtylyov [this message]
2013-08-09 13:37 ` Felipe Balbi
2013-08-06 19:46 ` [PATCH v2 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52014E0F.10404@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swarren@wwwdotorg.org \
--cc=ttynkkynen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox