From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: dmitry.torokhov@gmail.com, swarren@nvidia.com,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: tegra: use dt-binding header for key code
Date: Tue, 06 Aug 2013 13:28:50 -0600 [thread overview]
Message-ID: <52014E72.2070604@wwwdotorg.org> (raw)
In-Reply-To: <1375798370-2231-2-git-send-email-ldewangan@nvidia.com>
On 08/06/2013 08:12 AM, Laxman Dewangan wrote:
> In place of hardcoding the key code in DTS file and comment the key code
> as side notes, use the key code macro defines in the dt-bindings/input/input.h
> directly.
This one also looks fine to me. I'll wait for an updated version that
converts everything once patch 1/2 is accepted/applied.
next prev parent reply other threads:[~2013-08-06 19:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 14:12 [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes Laxman Dewangan
2013-08-06 14:12 ` [PATCH 2/2] ARM: tegra: use dt-binding header for key code Laxman Dewangan
2013-08-06 19:28 ` Stephen Warren [this message]
2013-08-06 14:28 ` [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes Jason Cooper
2013-08-06 19:28 ` Stephen Warren
2013-08-08 17:11 ` Laxman Dewangan
2013-08-08 17:13 ` Dmitry Torokhov
2013-08-08 17:25 ` Stephen Warren
2013-08-12 17:15 ` Dmitry Torokhov
2013-08-12 17:59 ` Stephen Warren
2013-08-19 14:53 ` Laxman Dewangan
2013-08-19 16:24 ` Stephen Warren
2013-08-19 22:35 ` Rob Herring
2013-08-08 17:32 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52014E72.2070604@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox