From: Li Zefan <lizefan@huawei.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Al Viro <viro@zeniv.linux.org.uk>, <xi.wang@gmail.com>,
<nicolas.dichtel@6wind.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result'
Date: Wed, 7 Aug 2013 15:02:35 +0800 [thread overview]
Message-ID: <5201F10B.7040102@huawei.com> (raw)
In-Reply-To: <5201E805.2080008@asianux.com>
>> To be honest...
>>
>> You are too bad in english to do kernel development. You don't seem to
>> know how to communicate in english...
>>
>
> So I should improve my English, and now I am just trying improving.
>
> At least, it is not an excuse to leave upstream kernel development, is
> it right ? or do you have additional ideas or suggestions ?
>
Two sugguestions.
The first one is, if you get a reply from a maintainer (especially a top
maintainer), try harder to understand/learn from that reply, but don't
keep asking why and don't keep arguing without much thinking. I think
what's why sometimes people are annoyed in the discussion with you.
The second one is, better focus on a specific subsystem and try to do some
real work. It's not bad to start making patches like this one, but it won't
do you any good in the long term. Don't get addicted in increasing patch
contribution.
next prev parent reply other threads:[~2013-08-07 7:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 7:29 [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result' Chen Gang
2013-08-06 21:43 ` Andrew Morton
2013-08-06 22:11 ` Joe Perches
2013-08-07 3:53 ` Chen Gang
2013-08-06 22:13 ` Eric W. Biederman
2013-08-07 5:28 ` Chen Gang F T
2013-08-07 5:11 ` Chen Gang
2013-08-06 21:46 ` Eric W. Biederman
2013-08-07 5:07 ` Chen Gang
2013-08-07 5:56 ` Li Zefan
2013-08-07 6:10 ` Joe Perches
2013-08-07 6:29 ` Chen Gang
2013-08-07 6:42 ` Li Zefan
2013-08-07 6:42 ` Li Zefan
2013-08-07 6:57 ` Chen Gang
2013-08-07 6:24 ` Chen Gang
2013-08-07 6:29 ` Andrew Morton
2013-08-07 6:34 ` Chen Gang
2013-08-07 7:02 ` Li Zefan [this message]
2013-08-07 8:03 ` Chen Gang
2013-08-07 8:44 ` Li Zefan
2013-08-07 9:13 ` Chen Gang
2013-08-07 7:45 ` Eric W. Biederman
2013-08-07 10:25 ` Chen Gang
2013-08-07 18:38 ` Eric W. Biederman
2013-08-08 3:19 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5201F10B.7040102@huawei.com \
--to=lizefan@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox