public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Li Zefan <lizefan@huawei.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	xi.wang@gmail.com, nicolas.dichtel@6wind.com,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result'
Date: Wed, 07 Aug 2013 16:03:17 +0800	[thread overview]
Message-ID: <5201FF45.8000906@asianux.com> (raw)
In-Reply-To: <5201F10B.7040102@huawei.com>

On 08/07/2013 03:02 PM, Li Zefan wrote:
>>> To be honest...
>>>
>>> You are too bad in english to do kernel development. You don't seem to
>>> know how to communicate in english...
>>>
>>
>> So I should improve my English, and now I am just trying improving.
>>
>> At least, it is not an excuse to leave upstream kernel development, is
>> it right ?  or do you have additional ideas or suggestions ?
>>
> 
> Two sugguestions.
> 

Firstly, thank you for your suggestions.


> The first one is, if you get a reply from a maintainer (especially a top
> maintainer), try harder to understand/learn from that reply, but don't
> keep asking why and don't keep arguing without much thinking. I think
> what's why sometimes people are annoyed in the discussion with you.
> 

In my opinion, "understand/learn" means:

  learn the proof which the author supplied;
  understand the author's opinion;
  know about what the author wants to do now (especially why he intents to send/reply mail to you).

But "understand/learn" does not mean:

  familiar about the 'professional' details.
  if each related member knows about the 'professional' details, it only need a work flow, not need discussing.

Do you think so too ?


Hmm... for each reply, I think it has 3 requirements:

  1. match the original contents which we want to reply.
  2. say opinion clearly.
  3. provide proof.

I guess your suggestion is for 1st: if we can not understand/learn from
the original contents, of cause, our reply can not match it.

Since discussing is thinking process, and we may get more understanding
during thinking, so it permits to continue reply multiple times (if for
each reply is qualified with the 3 requirements above).


Have you ever seen some of my reply which misunderstand(or not learn
enough) from original contents ?

Maybe you often saw that I continue reply multiple times for a thread,
but I think, each reply matches the 3 requirements above.


> The second one is, better focus on a specific subsystem and try to do some
> real work. It's not bad to start making patches like this one, but it won't
> do you any good in the long term. Don't get addicted in increasing patch
> contribution.

Hmm... I think what you said above is about ways (or method).

For ways, it is meaningless to say which is better or bad, it depends
on one's goal, one's environments, and one's resources.

So, every member need think of it, and find their own suitable ways to
continue providing their contributions to outside with efficiency.


Thanks.
-- 
Chen Gang

  reply	other threads:[~2013-08-07  8:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06  7:29 [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result' Chen Gang
2013-08-06 21:43 ` Andrew Morton
2013-08-06 22:11   ` Joe Perches
2013-08-07  3:53     ` Chen Gang
2013-08-06 22:13   ` Eric W. Biederman
2013-08-07  5:28     ` Chen Gang F T
2013-08-07  5:11   ` Chen Gang
2013-08-06 21:46 ` Eric W. Biederman
2013-08-07  5:07   ` Chen Gang
2013-08-07  5:56     ` Li Zefan
2013-08-07  6:10       ` Joe Perches
2013-08-07  6:29         ` Chen Gang
2013-08-07  6:42         ` Li Zefan
2013-08-07  6:42         ` Li Zefan
2013-08-07  6:57           ` Chen Gang
2013-08-07  6:24       ` Chen Gang
2013-08-07  6:29         ` Andrew Morton
2013-08-07  6:34           ` Chen Gang
2013-08-07  7:02         ` Li Zefan
2013-08-07  8:03           ` Chen Gang [this message]
2013-08-07  8:44             ` Li Zefan
2013-08-07  9:13               ` Chen Gang
2013-08-07  7:45     ` Eric W. Biederman
2013-08-07 10:25       ` Chen Gang
2013-08-07 18:38         ` Eric W. Biederman
2013-08-08  3:19           ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5201FF45.8000906@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xi.wang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox