From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756293Ab3HGPtG (ORCPT ); Wed, 7 Aug 2013 11:49:06 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:59909 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797Ab3HGPtE (ORCPT ); Wed, 7 Aug 2013 11:49:04 -0400 Message-ID: <52026C66.2080509@ti.com> Date: Wed, 7 Aug 2013 10:48:54 -0500 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: , , , Subject: Re: OPP: rename functions? (was [PATCH] OPP: Export opp_add()) References: <58acb4a8a4e98089078de3ed71999730b6d97b4b.1375521724.git.viresh.kumar@linaro.org> <5200F1B4.6050004@infradead.org> <20130806130820.GA6035@kahuna> <1611420.5h2rr9N0mt@vostro.rjw.lan> In-Reply-To: <1611420.5h2rr9N0mt@vostro.rjw.lan> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rafael, offline question: On 08/06/2013 09:15 AM, Rafael J. Wysocki wrote: > On Tuesday, August 06, 2013 08:08:20 AM Nishanth Menon wrote: >> change in subject to reflect new discussion. >> >> On 05:53-20130806, Randy Dunlap wrote: >>> On 08/03/2013 02:25 AM, Viresh Kumar wrote: >>>> +EXPORT_SYMBOL_GPL(opp_add); >>> >>> Could it be renamed to pm_opp_add() or power_opp_add() ? >>> The name is a bit too unspecific IMO. >> Though this has nothing specific with this patch, an interesting point. >> >> git grep -w opp . showed drivers/tty/n_tty.c, >> drivers/sbus/char/openprom.c and arch/powerpc/kvm/mpic.c using >> variables named opp to mean what ever they had in context. rest(around >> 40 odd files) seem to use opp as in Documentation/power/opp.txt.. >> >> We could go with a pm_ prefix or even dev_pm_opp_ prefix to be more >> specific, though I prefer just pm_. If Rafael and others are ok, I can >> post a series out. > > Yup, that would be useful. I'm for dev_pm_opp_ if that matters. Given that there would be quiet a few conflicts, do you have a suggestion around what baseline I should submit this? -- Regards, Nishanth Menon