Re: [PATCH 6/7] btrfs: cleanup: removed unused 'btrfs_reada_detach'

David Sterba
2013-08-08T22:00:43Z

On Thu, Aug 08, 2013 at 09:11:01PM +0200, Arne Jansen wrote:
> On 08/08/13 19:46, Zach Brown wrote:
> >>> even though the function is currently unused, I'm hesitating to remove it
> >>> as it's part of the reada-API and might be handy for anyone going to use
> >>> the API in the future.
> >>
> >> I agree. As replied here,
> >> http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg24047.html
> >> please keep the function.
> >
> > If we're keeping score, put me down for being in favour of removing dead
> > untested code. git ressurection is easy.
>
> It's not really untested, it has been in use some time ago. But of
> course there's a chance that some changes broke it.
> Yes, git ressurection is easy. To inform potential users, you might
> just leave a comment like this:
>
> /*
> * There has been a function once to detach from a running reada.
> * If you need such functionality, just revert the commit that
> * added this comment.
> */

And please write the exact commit sha1 instead of 'the commit' :)

I've used the _detach function when prototyping readdir readahead, that
did not bring the speedup as expected so more work is needed, that's why
I'm concerned about removing it. But, if Arne is ok with that, so be it.

david