Re: [PATCH 3/7] btrfs: cleanup: mark 'btrfs_write_and_wait_marked_extents' as static

David Sterba
2013-08-08T13:39:07Z

On Thu, Aug 08, 2013 at 12:43:19AM +0300, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <slyfox@gentoo.org>
>
> Found by uselex.rb:
> > btrfs_write_and_wait_marked_extents: [R]: exported from: fs/btrfs/btrfs.o fs/btrfs/transaction.o fs/btrfs/built-in.o
>
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
> fs/btrfs/transaction.c | 4 ++--
> fs/btrfs/transaction.h | 2 --
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> index d58cce7..ff891d2 100644
> --- a/fs/btrfs/transaction.c
> +++ b/fs/btrfs/transaction.c
> @@ -837,8 +837,8 @@ int btrfs_wait_marked_extents(struct btrfs_root *root,
> * them in one of two extent_io trees. This is used to make sure all of
> * those extents are on disk for transaction or log commit
> */
> -int btrfs_write_and_wait_marked_extents(struct btrfs_root *root,
> - struct extent_io_tree *dirty_pages, int mark)
> +static int btrfs_write_and_wait_marked_extents(struct btrfs_root *root,
> + struct extent_io_tree *dirty_pages, int mark)

You may want to run the output through checkpatch.pl and fix obvious
style violations (line too long).

david