Re: [PATCH 6/7] btrfs: cleanup: removed unused 'btrfs_reada_detach'

Arne Jansen
2013-08-08T07:39:16Z

On 07.08.2013 23:43, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <slyfox@gentoo.org>
>
> Found by uselex.rb:
>> btrfs_reada_detach: [R]: exported from: fs/btrfs/btrfs.o fs/btrfs/built-in.o fs/btrfs/reada.o

even though the function is currently unused, I'm hesitating to remove it
as it's part of the reada-API and might be handy for anyone going to use
the API in the future.

-Arne

>
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
> fs/btrfs/ctree.h | 1 -
> fs/btrfs/reada.c | 9 +--------
> 2 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index e91ab9e..f35e086 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -3861,7 +3861,6 @@ struct reada_control {
> struct reada_control *btrfs_reada_add(struct btrfs_root *root,
> struct btrfs_key *start, struct btrfs_key *end);
> int btrfs_reada_wait(void *handle);
> -void btrfs_reada_detach(void *handle);
> int btree_readahead_hook(struct btrfs_root *root, struct extent_buffer *eb,
> u64 start, int err);
>
> diff --git a/fs/btrfs/reada.c b/fs/btrfs/reada.c
> index 1031b69..c41d470 100644
> --- a/fs/btrfs/reada.c
> +++ b/fs/btrfs/reada.c
> @@ -37,7 +37,7 @@
> * To trigger a readahead, btrfs_reada_add must be called. It will start
> * a read ahead for the given range [start, end) on tree root. The returned
> * handle can either be used to wait on the readahead to finish
> - * (btrfs_reada_wait), or to send it to the background (btrfs_reada_detach).
> + * (btrfs_reada_wait).
> *
> * The read ahead works as follows:
> * On btrfs_reada_add, the root of the tree is inserted into a radix_tree.
> @@ -979,10 +979,3 @@ int btrfs_reada_wait(void *handle)
> return 0;
> }
> #endif
> -
> -void btrfs_reada_detach(void *handle)
> -{
> - struct reada_control *rc = handle;
> -
> - kref_put(&rc->refcnt, reada_control_release);
> -}