From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933110Ab3HHFwj (ORCPT ); Thu, 8 Aug 2013 01:52:39 -0400 Received: from mga14.intel.com ([143.182.124.37]:50220 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932149Ab3HHFwi (ORCPT ); Thu, 8 Aug 2013 01:52:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,837,1367996400"; d="scan'208";a="279248740" Message-ID: <5203337B.4040906@intel.com> Date: Thu, 08 Aug 2013 08:58:19 +0300 From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: David Ahern CC: acme@ghostprotocols.net, linux-kernel@vger.kernel.org, Jiri Olsa Subject: Re: [PATCH] perf tests: Fix compile failure on do_sort_something References: <1375912782-74921-1-git-send-email-dsahern@gmail.com> In-Reply-To: <1375912782-74921-1-git-send-email-dsahern@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/13 00:59, David Ahern wrote: > Commit b55ae0a9 added code-reading.c which fails to compile on Fedora 16 > with compiler version: > $ gcc --version > gcc (GCC) 4.6.3 20120306 (Red Hat 4.6.3-2) > > Failure message is: > > tests/code-reading.c: In function ‘do_sort_something’: > tests/code-reading.c:305:13: error: stack protector not protecting local variables: variable length buffer [-Werror=stack-protector] > cc1: all warnings being treated as errors > make: *** [/tmp/junk/tests/code-reading.o] Error 1 > make: *** Waiting for unfinished jobs.... > > Signed-off-by: David Ahern > Cc: Adrian Hunter > Cc: Jiri Olsa > --- > tools/perf/tests/code-reading.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c > index 8e0943b..4bde8be 100644 > --- a/tools/perf/tests/code-reading.c > +++ b/tools/perf/tests/code-reading.c > @@ -304,15 +304,14 @@ static int comp(const void *a, const void *b) > > static void do_sort_something(void) > { > - size_t sz = 40960; > - int buf[sz], i; > + int buf[40960], i; > > - for (i = 0; i < (int)sz; i++) > - buf[i] = sz - i - 1; > + for (i = 0; i < (int)sizeof(buf); i++) Should that be ARRAY_SIZE not sizeof > + buf[i] = sizeof(buf) - i - 1; > > - qsort(buf, sz, sizeof(int), comp); > + qsort(buf, sizeof(buf), sizeof(int), comp); > > - for (i = 0; i < (int)sz; i++) { > + for (i = 0; i < (int)sizeof(buf); i++) { > if (buf[i] != i) { > pr_debug("qsort failed\n"); > break; >