Re: [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page

David Howells
2023-05-26T08:32:27Z

Christoph Hellwig <hch@infradead.org> wrote:

> > +void page_get_additional_pin(struct page *page)
>
> page_get_additional_pin seems like an odd name, mixing the get and
> pin terminologies. What about repin_page?

I considered that, though repin_page() suggests putting a pin back in after
one is removed, but I can go with that if no one objects.

> Or move to a folio interface from the start can call it folio_repin?

I also considered this, but the entire gup interface is page-based at the
moment, but I can do that too:-/

David