Re: [RFC PATCH v2 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages()

David Howells
2023-05-26T08:30:21Z

Christoph Hellwig <hch@infradead.org> wrote:

> Shouldn't unpin_user_pages

It calls gup_put_folio() which is where the skip is.

> and bio_release_page also be updated to skip a zero page here?

Porbably best to leave it to unpin_user_page() there. I've tried to hide the
behaviour entirely within gup.c.

David