From: Oliver Neukum <oneukum@suse.de>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Josh Boyer <jwboyer@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
gregkh@linuxfoundation.org, mdharm-usb@one-eyed-alien.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: USB autosuspend vs. URB submission
Date: Thu, 10 Jan 2013 11:02:11 +0100 [thread overview]
Message-ID: <5203913.6Ij3EG26lC@linux-5eaq.site> (raw)
In-Reply-To: <CACVXFVNUJ8i5hOX8oqcBn1rO=KmHQU3WMBVBh9HF=BfJw1QcPw@mail.gmail.com>
On Thursday 10 January 2013 13:13:58 Ming Lei wrote:
> IMO, there is a minor fault in the error handling path of
> uvc_status_start() inside uvc_v4l2_open(), and the 'users' count
> should have been decreased before usb_autopm_put_interface().
> In theory, the warning can be triggered when the device is
> opened just between usb_autopm_put_interface() and
> atomic_dec(&stream->dev->users), but I don't think it is
> the cause of the report.
Hi,
the analysis is sound. Good catch. As the fix is trivial, I am making
a quick patch.
Regards
Oliver
next prev parent reply other threads:[~2013-01-10 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 20:42 USB autosuspend vs. URB submission Josh Boyer
2013-01-08 15:51 ` Alan Stern
2013-01-08 16:03 ` Josh Boyer
2013-01-09 23:05 ` Laurent Pinchart
2013-01-10 5:13 ` Ming Lei
2013-01-10 10:02 ` Oliver Neukum [this message]
2013-01-10 9:42 ` Oliver Neukum
2013-01-10 15:20 ` Alan Stern
2013-01-10 15:37 ` Oliver Neukum
2013-01-10 15:13 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203913.6Ij3EG26lC@linux-5eaq.site \
--to=oneukum@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=jwboyer@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox