public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Wei Ni <wni@nvidia.com>
Cc: khali@linux-fr.org, linux@roeck-us.net, MLongnecker@nvidia.com,
	linux-arm-kernel@lists.infradead.org, lm-sensors@lm-sensors.org,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2 3/3] Documentation: dt: hwmon: add OF document for lm90
Date: Thu, 08 Aug 2013 11:37:27 -0600	[thread overview]
Message-ID: <5203D757.8000208@wwwdotorg.org> (raw)
In-Reply-To: <1375944991-29182-4-git-send-email-wni@nvidia.com>

On 08/08/2013 12:56 AM, Wei Ni wrote:
> Add OF document for lm90 in Documentation/devicetree/.

> diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt b/Documentation/devicetree/bindings/hwmon/lm90.txt

> +Required node properties:
> +- compatible: manufacture and chip name,
> +              which are listed in the Documentation/hwmon/lm90

You need to specify the exact values here. DT binding documentations
should be OS-agnostic, and hence can't depend on Linux-specific
documentation or other details.

> +Optional properties:
> +- vdd-supply: vdd regulator for the supply voltage. If this is not set,

s/set/present/.

> +- interrupts: lm90 can support interrupt mode, you can set interrupt here.

You might want to mention that a single entry ("specifier") is expected
in the list.

  reply	other threads:[~2013-08-08 17:37 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08  6:56 [PATCH v2 0/3] Add power control for lm90 Wei Ni
2013-08-08  6:56 ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-08  7:13   ` Alexander Shiyan
2013-08-08  9:26     ` Wei Ni
2013-08-08  8:42   ` Guenter Roeck
2013-08-08  9:47     ` Wei Ni
2013-08-08  9:57       ` Alexander Shiyan
2013-08-08  9:59         ` Wei Ni
2013-08-08 10:07         ` Wei Ni
2013-08-08 11:23       ` Guenter Roeck
2013-08-08 17:33         ` Stephen Warren
2013-08-08 17:59           ` Guenter Roeck
2013-08-08 18:45             ` Stephen Warren
2013-08-08 17:30     ` Stephen Warren
2013-08-08 17:59       ` Guenter Roeck
2013-08-08 19:27       ` Mark Brown
2013-08-08 11:01   ` Mark Brown
2013-08-08 11:25     ` Guenter Roeck
2013-08-08 13:08       ` Mark Brown
2013-08-08 15:21         ` Guenter Roeck
2013-08-08 17:15           ` Mark Brown
2013-08-08 20:00             ` Guenter Roeck
2013-08-08 21:18               ` Mark Brown
2013-08-08 21:30                 ` Guenter Roeck
2013-08-09  5:57                   ` Proposal: I2C device power (Was: hwmon: (lm90) Add power control) Alexander Shiyan
2013-08-09 10:27                     ` Mark Brown
2013-08-09 10:50                       ` Alexander Shiyan
2013-08-09 11:09                         ` Mark Brown
2013-08-09  7:23     ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-09 10:56       ` Mark Brown
2013-08-08  6:56 ` [PATCH v2 2/3] ARM: dt: t114 dalmore: add dt entry for nct1008 Wei Ni
2013-08-08 17:35   ` Stephen Warren
2013-08-09  6:06     ` Wei Ni
2013-08-08 20:36   ` Sergei Shtylyov
2013-08-08 20:40     ` Stephen Warren
2013-08-08 21:33       ` Guenter Roeck
2013-08-09  6:16         ` Wei Ni
2013-08-08  6:56 ` [PATCH v2 3/3] Documentation: dt: hwmon: add OF document for lm90 Wei Ni
2013-08-08 17:37   ` Stephen Warren [this message]
2013-08-09  6:10     ` Wei Ni
2013-08-09 16:35       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5203D757.8000208@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=MLongnecker@nvidia.com \
    --cc=khali@linux-fr.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=wni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox