From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Shuah Khan" <shuah@kernel.org>
Cc: usama.anjum@collabora.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] selftests/timens: timerfd: Use correct clockid type in tclock_gettime()
Date: Fri, 2 May 2025 17:14:02 +0500 [thread overview]
Message-ID: <5203d87f-a098-4f76-81cb-4966181de4eb@collabora.com> (raw)
In-Reply-To: <20250502-selftests-timens-fixes-v1-3-fb517c76f04d@linutronix.de>
On 5/2/25 5:03 PM, Thomas Weißschuh wrote:
> tclock_gettime() is a wrapper around clock_gettime().
> The first parameter of clock_gettime() is of type "clockid_t",
> not "clock_t".
>
> Use the correct type instead.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/timens/timerfd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/timens/timerfd.c b/tools/testing/selftests/timens/timerfd.c
> index d6adf66bd8df064f5b76ccc265c13217d7a53f5b..402e2e4155450d946796b8297a8be85f93cea16f 100644
> --- a/tools/testing/selftests/timens/timerfd.c
> +++ b/tools/testing/selftests/timens/timerfd.c
> @@ -15,7 +15,7 @@
> #include "log.h"
> #include "timens.h"
>
> -static int tclock_gettime(clock_t clockid, struct timespec *now)
> +static int tclock_gettime(clockid_t clockid, struct timespec *now)
> {
> if (clockid == CLOCK_BOOTTIME_ALARM)
> clockid = CLOCK_BOOTTIME;
>
--
Regards,
Usama
prev parent reply other threads:[~2025-05-02 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 12:03 [PATCH 0/3] selftests/timens: Various small fixes Thomas Weißschuh
2025-05-02 12:03 ` [PATCH 1/3] selftests/timens: Print TAP headers Thomas Weißschuh
2025-05-02 12:13 ` Muhammad Usama Anjum
2025-05-07 21:06 ` Shuah Khan
2025-05-09 15:41 ` Thomas Weißschuh
2025-05-09 18:53 ` Shuah Khan
2025-05-09 19:07 ` Kees Cook
2025-05-02 12:03 ` [PATCH 2/3] selftests/timens: Make run_tests() functions static Thomas Weißschuh
2025-05-02 12:13 ` Muhammad Usama Anjum
2025-05-02 12:03 ` [PATCH 3/3] selftests/timens: timerfd: Use correct clockid type in tclock_gettime() Thomas Weißschuh
2025-05-02 12:14 ` Muhammad Usama Anjum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203d87f-a098-4f76-81cb-4966181de4eb@collabora.com \
--to=usama.anjum@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox