From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932195AbbJMVBI (ORCPT <rfc822;w@1wt.eu>);
	Tue, 13 Oct 2015 17:01:08 -0400
Received: from mout.kundenserver.de ([212.227.126.187]:54503 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753079AbbJMVBE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 13 Oct 2015 17:01:04 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Ray Jui <rjui@broadcom.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>, linux-arm-kernel@lists.infradead.org,
        Kevin Hilman <khilman@kernel.org>,
        Tyler Baker <tyler.baker@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>, Olof Johansson <olof@lixom.net>,
        Mark Brown <broonie@kernel.org>, bcm-kernel-feedback-list@broadcom.com,
        Linux PCI <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: iproc: fix 32-bit build error
Date: Tue, 13 Oct 2015 23:00:31 +0200
Message-ID: <5204456.Kxa6kNhPYW@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <561D6576.2020107@broadcom.com>
References: <1442363962-29805-1-git-send-email-rjui@broadcom.com> <561D6458.40504@hauke-m.de> <561D6576.2020107@broadcom.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:z4YV9N1EJBDChwXtIo00+Fd/fdpZZDkWfHMekceeNnyqKHmxi62
 8x1NcRzvsY3keAIp6jhg9PhW/hRrgKMUbSiAwm/07cHcts11P6UGHfkmj1CeujjuZ4MaVEw
 ac2AX7hanl5R7DNxTDXMgYG94rqLzHaUWBOr3/ZGLOdlf1/oQXISJH8RersGX1a5qwY68MK
 r1qYHOg++Q7pm4YP0AJiA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:etx8KFPKRI4=:si4S+RhWAMT51VuutMBV6C
 uRyPYBRTtjiPnSFtLnc+ZsQ35zVdbpCT0waOJfDzTW/mgfqz5Z0cBi5gtAkBidCkBdZZMVjSV
 /MXhIJF/EBodcyW3vDUSRR6aqZ8fdc1iS5VSBtjroHuX5WZ/NWiHO+eOWWWUz+WwNUD/tojjv
 k4XdwdLBwUOAalm9H9w14qPPN36ITJkP3pMy7gjW3Mzh7l3kEwOzQSprcycCmfGvSu8fqf9rb
 cIaPe6MwwRel50t9fqeP2U0i9NNUyMopqIyNfTN/qGkHl/fpG7+qUmnpuq/ByrxKOA6tBxvWc
 drDVVQGT6T2fNPeXx/ZiFEpna63hX9yoSpBcZvpaBUUIKrGmAkyNC8nCcynfcMfFYBrPOXHJU
 AiML32yE6EtUi7H18O+CG7FD6hVb2nRN377cUuEg8b32uHc1wM5uVJcdVFA/sv4FHnrci/2Kr
 7tif5CrOd1ZHKyOILOlSLQG2gFwktRc1UiDDCqeeT6x0gbvwTGc+2DDDyu7I2dVNmKRBPluD4
 2drBxvxYOzUND6ylWuKHSKshIQTNgn4ZvrONGb9LEj82Ob4yPRgCG1XHmn9vYB1BUIHn7+570
 eViILF4MijlQ+hUUQ0RzQEFy+CmZRLGFEeFFcxgnHsHdeR+6Lu4UlDvXjS4JKexjNvbxZ99ox
 F0ldZbIAK0Km/7hz33ZCm2sc8Uzy36nkD3qmxdK8FNOfUEUtpxSHXqku9/vC2pO5dlLF6MOIT
 CQMLymq6U7URKPWq
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 13 October 2015 13:11:34 Ray Jui wrote:
> >> diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c
> >> index f3481ddff344..abcb4be2ee19 100644
> >> --- a/drivers/pci/host/pcie-iproc.c
> >> +++ b/drivers/pci/host/pcie-iproc.c
> >> @@ -235,12 +235,13 @@ static void iproc_pcie_enable(struct iproc_pcie *pcie)
> >>   *
> >>   * axi_addr -> iproc_pcie_address -> OARR -> OMAP -> pci_address
> >>   */
> >> -static int iproc_pcie_setup_ob(struct iproc_pcie *pcie, u64 axi_addr,
> >> +int iproc_pcie_setup_ob(struct iproc_pcie *pcie, u64 axi_addr,
> > 
> > Why are you removing the static here?
> > 
> 
> Yeah we should keep this function as static. The rest of this change
> looks good!
> 

Sorry, this accidentally ended up in the patch when I marked the
function as global to track down how the division got called.

I'll send a new version.

	Arnd