* [PATCH] perf tests: Fix compile failure on do_sort_something
@ 2013-08-07 21:59 David Ahern
2013-08-08 5:58 ` Adrian Hunter
0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2013-08-07 21:59 UTC (permalink / raw)
To: acme, linux-kernel; +Cc: David Ahern, Adrian Hunter, Jiri Olsa
Commit b55ae0a9 added code-reading.c which fails to compile on Fedora 16
with compiler version:
$ gcc --version
gcc (GCC) 4.6.3 20120306 (Red Hat 4.6.3-2)
Failure message is:
tests/code-reading.c: In function ‘do_sort_something’:
tests/code-reading.c:305:13: error: stack protector not protecting local variables: variable length buffer [-Werror=stack-protector]
cc1: all warnings being treated as errors
make: *** [/tmp/junk/tests/code-reading.o] Error 1
make: *** Waiting for unfinished jobs....
Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
---
tools/perf/tests/code-reading.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c
index 8e0943b..4bde8be 100644
--- a/tools/perf/tests/code-reading.c
+++ b/tools/perf/tests/code-reading.c
@@ -304,15 +304,14 @@ static int comp(const void *a, const void *b)
static void do_sort_something(void)
{
- size_t sz = 40960;
- int buf[sz], i;
+ int buf[40960], i;
- for (i = 0; i < (int)sz; i++)
- buf[i] = sz - i - 1;
+ for (i = 0; i < (int)sizeof(buf); i++)
+ buf[i] = sizeof(buf) - i - 1;
- qsort(buf, sz, sizeof(int), comp);
+ qsort(buf, sizeof(buf), sizeof(int), comp);
- for (i = 0; i < (int)sz; i++) {
+ for (i = 0; i < (int)sizeof(buf); i++) {
if (buf[i] != i) {
pr_debug("qsort failed\n");
break;
--
1.7.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf tests: Fix compile failure on do_sort_something
2013-08-07 21:59 [PATCH] perf tests: Fix compile failure on do_sort_something David Ahern
@ 2013-08-08 5:58 ` Adrian Hunter
2013-08-09 3:09 ` David Ahern
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Hunter @ 2013-08-08 5:58 UTC (permalink / raw)
To: David Ahern; +Cc: acme, linux-kernel, Jiri Olsa
On 08/08/13 00:59, David Ahern wrote:
> Commit b55ae0a9 added code-reading.c which fails to compile on Fedora 16
> with compiler version:
> $ gcc --version
> gcc (GCC) 4.6.3 20120306 (Red Hat 4.6.3-2)
>
> Failure message is:
>
> tests/code-reading.c: In function ‘do_sort_something’:
> tests/code-reading.c:305:13: error: stack protector not protecting local variables: variable length buffer [-Werror=stack-protector]
> cc1: all warnings being treated as errors
> make: *** [/tmp/junk/tests/code-reading.o] Error 1
> make: *** Waiting for unfinished jobs....
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> ---
> tools/perf/tests/code-reading.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c
> index 8e0943b..4bde8be 100644
> --- a/tools/perf/tests/code-reading.c
> +++ b/tools/perf/tests/code-reading.c
> @@ -304,15 +304,14 @@ static int comp(const void *a, const void *b)
>
> static void do_sort_something(void)
> {
> - size_t sz = 40960;
> - int buf[sz], i;
> + int buf[40960], i;
>
> - for (i = 0; i < (int)sz; i++)
> - buf[i] = sz - i - 1;
> + for (i = 0; i < (int)sizeof(buf); i++)
Should that be ARRAY_SIZE not sizeof
> + buf[i] = sizeof(buf) - i - 1;
>
> - qsort(buf, sz, sizeof(int), comp);
> + qsort(buf, sizeof(buf), sizeof(int), comp);
>
> - for (i = 0; i < (int)sz; i++) {
> + for (i = 0; i < (int)sizeof(buf); i++) {
> if (buf[i] != i) {
> pr_debug("qsort failed\n");
> break;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf tests: Fix compile failure on do_sort_something
2013-08-08 5:58 ` Adrian Hunter
@ 2013-08-09 3:09 ` David Ahern
0 siblings, 0 replies; 3+ messages in thread
From: David Ahern @ 2013-08-09 3:09 UTC (permalink / raw)
To: Adrian Hunter; +Cc: acme, linux-kernel, Jiri Olsa
On 8/8/13 1:58 AM, Adrian Hunter wrote:
> On 08/08/13 00:59, David Ahern wrote:
>> Commit b55ae0a9 added code-reading.c which fails to compile on Fedora 16
>> with compiler version:
>> $ gcc --version
>> gcc (GCC) 4.6.3 20120306 (Red Hat 4.6.3-2)
>>
>> Failure message is:
>>
>> tests/code-reading.c: In function ‘do_sort_something’:
>> tests/code-reading.c:305:13: error: stack protector not protecting local variables: variable length buffer [-Werror=stack-protector]
>> cc1: all warnings being treated as errors
>> make: *** [/tmp/junk/tests/code-reading.o] Error 1
>> make: *** Waiting for unfinished jobs....
>>
>> Signed-off-by: David Ahern <dsahern@gmail.com>
>> Cc: Adrian Hunter <adrian.hunter@intel.com>
>> Cc: Jiri Olsa <jolsa@redhat.com>
>> ---
>> tools/perf/tests/code-reading.c | 11 +++++------
>> 1 file changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c
>> index 8e0943b..4bde8be 100644
>> --- a/tools/perf/tests/code-reading.c
>> +++ b/tools/perf/tests/code-reading.c
>> @@ -304,15 +304,14 @@ static int comp(const void *a, const void *b)
>>
>> static void do_sort_something(void)
>> {
>> - size_t sz = 40960;
>> - int buf[sz], i;
>> + int buf[40960], i;
>>
>> - for (i = 0; i < (int)sz; i++)
>> - buf[i] = sz - i - 1;
>> + for (i = 0; i < (int)sizeof(buf); i++)
>
>
> Should that be ARRAY_SIZE not sizeof
oops, yes it should.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-09 3:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-07 21:59 [PATCH] perf tests: Fix compile failure on do_sort_something David Ahern
2013-08-08 5:58 ` Adrian Hunter
2013-08-09 3:09 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox