From: Federico Vaga <federico.vaga@gmail.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Pawel Osciak <pawel@osciak.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags
Date: Tue, 08 Jan 2013 15:58:37 +0100 [thread overview]
Message-ID: <5204825.yR0kSsoYV4@harkonnen> (raw)
In-Reply-To: <50EBF7A9.6070802@samsung.com>
> Ok, then I would simply pass the flags from the driver without any
> alternation
> in the allocator itself, so drivers can pass 'GFP_KERNEL' or
> 'GFP_KERNEL | GFP_DMA' depending on their preference. Please also update
> all
> the existing clients of vb2_dma_dc allocator.
I taked a look at drivers that use dma-contig. They use the structure
vb2_alloc_ctx which is just a name, there is not a real vb2_alloc_ctx
structure implementation. "Now" driver must gain access to vb2_dc_conf to set
the correct flags.
I have the following ideas:
1. replace all the names and expose vb2_dc_conf to all drivers (like dma-
sg, it export vb2_dma_sg_desc to all its users)
2. create an helper which configure flags. This maintain the vb2_dc_conf
private
vb2_set_mem_flags(struct vb2_alloc_ctx *alloc_ctx, gfp_t flags)
3. rename vb2_dc_conf to vb2_alloc_ctx because it is an implementation
vb2_alloc_ctx and (at the moment) it is used only by dma-contig
--
Federico Vaga
prev parent reply other threads:[~2013-01-08 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 17:29 [PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags Federico Vaga
2013-01-06 17:29 ` [PATCH V4 2/3] sta2x11_vip: convert to videobuf2 and control framework Federico Vaga
2013-01-07 9:46 ` Hans Verkuil
2013-01-06 17:29 ` [PATCH V4 3/3] adv7180: remove {query/g_/s_}ctrl Federico Vaga
2013-01-08 6:53 ` [PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags Marek Szyprowski
2013-01-08 10:15 ` Federico Vaga
2013-01-08 10:40 ` Marek Szyprowski
2013-01-08 14:58 ` Federico Vaga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204825.yR0kSsoYV4@harkonnen \
--to=federico.vaga@gmail.com \
--cc=corbet@lwn.net \
--cc=giancarlo.asnaghi@st.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@infradead.org \
--cc=mchehab@redhat.com \
--cc=pawel@osciak.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox