public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	Hyeoncheol Lee <cheol.lee@lge.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Oleg Nesterov <oleg@redhat.com>,
	"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH 03/13] tracing/kprobes: Make stack and memory fetch functions static
Date: Fri, 09 Aug 2013 18:15:50 +0900	[thread overview]
Message-ID: <5204B346.4010904@hitachi.com> (raw)
In-Reply-To: <87y58bwc44.fsf@sejong.aot.lge.com>

(2013/08/09 16:35), Namhyung Kim wrote:
> Hi Masami-san,
> 
> On Mon, 05 Aug 2013 18:04:09 +0900, Masami Hiramatsu wrote:
>> (2013/07/31 18:03), Namhyung Kim wrote:
>>> From: Namhyung Kim <namhyung.kim@lge.com>
>>>
>>> Those fetch functions need to be implemented differently for kprobes
>>> and uprobes.  Since the symbol and deref fetch functions don't call
>>> those directly anymore, we can make them static and implement them
>>> separately.
>>
>> Hmm, I think this should be done in 1/13, since this is partially
>> reverted it in the same series. If you concern about tweaking other
>> one's patch, you can add you singed-off-by to it. :)
> 
> The problem is that it should be marked static after converting to
> ->fetch() member.  Otherwise the symbol and deref fetch method won't see
> memory fetch functions like:

Ah, right. We still use it from deref. :)

Thanks!


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com



  reply	other threads:[~2013-08-09  9:15 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31  9:03 [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v2) Namhyung Kim
2013-07-31  9:03 ` [PATCH 01/13] tracing/kprobes: Move fetch functions to trace_kprobe.c Namhyung Kim
2013-08-05  5:30   ` Masami Hiramatsu
2013-08-05  8:44     ` Namhyung Kim
2013-07-31  9:03 ` [PATCH 02/13] tracing/kprobes: Add fetch{,_size} member into symbol and deref fetch method Namhyung Kim
2013-08-05  8:19   ` Masami Hiramatsu
2013-08-05  8:58     ` Namhyung Kim
2013-07-31  9:03 ` [PATCH 03/13] tracing/kprobes: Make stack and memory fetch functions static Namhyung Kim
2013-08-05  9:04   ` Masami Hiramatsu
2013-08-09  7:35     ` Namhyung Kim
2013-08-09  9:15       ` Masami Hiramatsu [this message]
2013-07-31  9:03 ` [PATCH 04/13] tracing/kprobes: Factor out struct trace_probe Namhyung Kim
2013-08-05  6:00   ` Masami Hiramatsu
2013-08-05  8:49     ` Namhyung Kim
2013-07-31  9:03 ` [PATCH 05/13] tracing/uprobes: Convert to " Namhyung Kim
2013-07-31  9:03 ` [PATCH 06/13] tracing/kprobes: Move common functions to trace_probe.c Namhyung Kim
2013-08-05  6:03   ` Masami Hiramatsu
2013-08-05  8:50     ` Namhyung Kim
2013-07-31  9:03 ` [PATCH 07/13] tracing/kprobes: Remove duplicate set_print_fmt() Namhyung Kim
2013-08-05  6:46   ` Masami Hiramatsu
2013-07-31  9:03 ` [PATCH 08/13] tracing/uprobes: Fetch args before reserving a ring buffer Namhyung Kim
2013-07-31  9:03 ` [PATCH 09/13] tracing/uprobes: Fix a comment for uprobe registration syntax Namhyung Kim
2013-08-05  5:59   ` Masami Hiramatsu
2013-08-05  8:47     ` Namhyung Kim
2013-07-31  9:03 ` [PATCH 10/13] tracing/kprobes: Add priv argument to fetch functions Namhyung Kim
2013-07-31  9:03 ` [PATCH 11/13] tracing/uprobes: Add more " Namhyung Kim
2013-07-31  9:03 ` [PATCH 12/13] tracing/uprobes: Add support for full argument access methods Namhyung Kim
2013-07-31  9:03 ` [PATCH 13/13] tracing/probes: Fix basic print type functions Namhyung Kim
2013-08-05  6:22   ` Masami Hiramatsu
2013-08-05  6:31     ` Joe Perches
2013-08-05  7:27       ` Masami Hiramatsu
2013-08-05  8:55       ` Namhyung Kim
2013-08-05  8:51     ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5204B346.4010904@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=acme@ghostprotocols.net \
    --cc=cheol.lee@lge.com \
    --cc=jovi.zhangwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=namhyung@kernel.org \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox